Fix issues due to _NewTemp methods, fixes heater/cooler temperature changes #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges RW update add `_NewTemp` methods instead of replacing existing ones to keep backwards compatibility with mods. This allows mods calling those methods to work as they used to, but it causes issues with Harmony patches since those are no longer called by vanilla code. The change here is to target the `_NewTemp` methods Harmony patches (sync methods) rather than the original ones. This should fix changing heater/cooler temperature settings as well as giving the players time to rename stillborn pawns (normally would be 1 tick in this situation).
SokyranTheDragon
added
fix
SokyranTheDragon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RW update add
_NewTempmethods instead of replacing existing ones to keep backwards compatibility with mods. This allows mods calling those methods to work as they used to, but it causes issues with Harmony patches since those are no longer called by vanilla code. The change here is to target the_NewTempmethods Harmony patches (sync methods) rather than the original ones.This should fix changing heater/cooler temperature settings as well as giving the players time to rename stillborn pawns (normally would be 1 tick in this situation).