Fix syncing of copy/paste gizmos for Biosculpter/Growth Vat/Mortar, fixes #255 #407
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes rwmt#255 This fixes issue of copy/paste gizmos not working properly for: - Growth vats (`Building_GrowthVat`) - Biosculpter pods (`CompBiosculpterPod`) - Mortars (`CompChangeableProjectile`) The issue happened due to the storages associated to those losing their owner after loading them through `ExposeData`. The solution was to re-assign their owner in PostLoadInit. The patch is included in the generic `Patches.cs` file, as I felt it did not really fit any other existing source file containing patches (potentially `VanillaTweaks.cs`). However, if needed I could create a separate file for them or move them to a different location. I can also split them into separate patches, so a single class doesn't contain 3 postfixes.
SokyranTheDragon
added
fix
|
I've reported the StorageSettings losing their owners on the official RimWorld Discord, so this may end up getting changed. However, since it does not break anything in the game itself it may not be a priority/is not guaranteed to be changed. |
SokyranTheDragon
added a commit
to SokyranTheDragon/Multiplayer
that referenced
this pull request
Apr 29, 2024
Remove the storage parent fix (rwmt#407) for growth vat, as this was fixed by vanilla.
Zetrith
pushed a commit
that referenced
this pull request
May 24, 2024
Remove the storage parent fix (#407) for growth vat, as this was fixed by vanilla.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue of copy/paste gizmos not working properly for:
Building_GrowthVat)CompBiosculpterPod)CompChangeableProjectile)The issue happened due to the storages associated to those losing their owner after loading them through
ExposeData. The solution was to re-assign their owner in PostLoadInit.The patch is included in the generic
Patches.csfile, as I felt it did not really fit any other existing source file containing patches (potentially could fit intoVanillaTweaks.cs).However, if needed I could create a separate file for them or move them to a different location. I can also split them into separate patches, so a single class doesn't contain 3 postfixes (I've put them all in the same class to have basically-identical patches together).