Update 0.9, multifaction #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notfood
reviewed
Oct 16, 2023
|
I've looked through most the changes. There were many additions/changes that were rather small and simple to understand, or removal of stuff I assumed are no longer needed - I mostly skimmed through those. As for the bigger changes, I'll have to look deeper into them. |
- Protocol 34 - Multifaction: new hosting option, faction creation screen, set faction context in more places, refactor code related to factions - Remove id blocks - Track getting unique ids in desync traces - Log stack traces in Sync command write log - Use my UI layout helper (Layouter.cs) from Prepatcher - Only set faction context when necessary (should slightly improve performance) - Move Native and DeferredStackTracingImpl to Common - Reorganize project dependencies (they previously doubled as artifact output control) - Move conversion to singleplayer into its own file - Split player cursor and location ping code - Remove HotSwappableAttribute - Fix applying the mod list with "Fix and restart" - Fix issues with desync tracing and latest Harmony - Fix desyncs related to autosaving and battle log - Fix exception when not including all arguments in SyncMethod exposeParameters - Fix clicking on files in save list sometimes not working
Use the multifaction hosting option Fix hosting from singleplayer saves
Fix saving of policies (outfits etc) Remove spectator faction when converting to sp
Zetrith
force-pushed
the
multifaction-oct
branch
from
9891264 to
1982990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes implementation of multifaction beta. The commit message has more details
Some small things are still missing, I'll add them soon: