Update rocket_ws dep to pick up security fix. #2823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be because the change log didn't mention it being fixed until 0.23.0 |
Do you know why? We can still update the dep, by the version we're depending on shouldn't be signaling issues. |
|
I have not heard back from our vendor yet. Will ping them again. |
|
Vendor got back to me and determined it was an error in their data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be needed...
This is the CVE that was reported in our code scans: https://nvd.nist.gov/vuln/detail/CVE-2023-43669
Rocket is already above that version, but our scans are still complaining.
I'm investigating, but will leave this open in case you just want to bump your deps.