Draft: Allow specifying a cache-control header for serving static files. #2264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first-time contributor here! I'd like to request some comments on this change before finalizing it and writing tests.
The idea is that when serving e.g. Javascript or image assets through Rocket, I'd like clients not to request the whole resource every time. I haven't found an established way of doing this in Rocket (except for serving static resources from a different webserver).
It's unclear to me if my solution is too hacky, but I've also not found a better place to implement this in. Maybe you can point me to it if there is.