Improved RoomCoordinate and RoomXY, new RoomOffset for optimized arithmetic
#543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can index into `[T; ROOM_SIZE]` to get `&(mut) T`, or `[T; ROOM_AREA]` to get `&(mut) [T; ROOM_SIZE]`.
Introduces wrapper types that can be used to index by `RoomXY` directly, instead of going coordinate-by-coordinate. Also replaces `ROOM_SIZE as usize` with `ROOM_USIZE`, where used.
Implicitly allows direct access to `bits`, in the form of the public `XMajor` member.
Removes unsafe block that directly converted to linear coordinates.
jciskey
approved these changes
Oct 9, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
khoover
changed the title
RoomCoordinate and RoomXYRoomCoordinate and RoomXY
Less buggy if we avoid literals and use the constant everywhere.
khoover
commented
Oct 14, 2024
Docs and tests to come.
For consistency's sake, return a `Result` from `RoomOffset::new` instead of an `Option`. Also better document all the new methods.
|
What I'd want to do is replace the |
khoover
changed the title
RoomCoordinate and RoomXYRoomCoordinate and RoomXY, new RoomOffset for optimized arithmetic
shanemadden
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds indexing impls for
RoomCoordinateand a wrapper type that allows indexing nested arrays byRoomXY. Re-writesLocalCostMatrixandLocalRoomTerrainindexing in terms of theRoomCoordinateindexing impls.Also adds a new
RoomOffsettype which can be used for better-optimized arithmetic, as well as being the output of coordinate-coordinate subtraction.