Fix undefined attributes on StructureController #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #458
hits/hitMax: Added coalesce from undefined to 0, as 0 is another value that the game uses for invulnerable structures in addition to undefined. This matches the current behavior when in release mode.upgradeBlocked,progress,progressTotal,ticksToDowngrade: 0 values wouldn't make sense for some of these, and all have cases where you'd expect them to be undefined. AddedOption<>wrap around returns for each.safeModeAvailable,isPowerEnabled: seems like these already coalesce to sane values when undefined: https://github.com/screeps/engine/blob/204f95545d8946782e65911abbcd020a256f1cd7/src/game/structures.js#L186-L198