Pathfinder / as_ref() #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creep and other types can convert to JsArray via as_ref() but not Object
wtfrank
force-pushed
the
pathfinder_as_ref
branch
from
3d491ab to
8915d18
Compare
shanemadden
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_path originally had &Object arguments. I've changed these to &JsArray which is what the rust world api uses for the equivalent function.
Creep can convert to &JsArray via as_ref() but not to Object.
I don't know if it's possible to give Creep an AsRef trait (new to wasm_bindgen) but I've been able to do pathfinding with this change.