project CI refresh #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reformats to better support parameters. * Adds merge_group trigger for supporting queued merges. * Adds cron scheduled build.
The `actions-rs/clippy-check` action is archived and there isn't a clear alternative. Since clippy is already being run in `rust.yml` the right fix seems to be removing this extra workflow.
This better matches what other rusticata crates are using.
Findings of the type:
```
warning: the item `AsMut` is imported redundantly
--> src/utils.rs:1:20
|
1 | use std::convert::{AsMut, AsRef};
| ^^^^^
--> /rustc/a165f1f65015b1bd4afd2ec50700aaacf2e0c485/library/std/src/prelude/mod.rs:115:13
|
= note: the item `AsMut` is already defined here
|
= note: `#[warn(unused_imports)]` on by default
```
Of the form:
```
error: unnecessary qualification
--> src/error.rs:67:8
|
67 | I: std::fmt::Debug,
| ^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:117:31
|
117 | unused_import_braces, unused_qualifications)]
| ^^^^^^^^^^^^^^^^^^^^^
help: remove the unnecessary path segments
|
67 - I: std::fmt::Debug,
67 + I: fmt::Debug,
```
```
error: usage of a legacy numeric constant
--> src/pcapng.rs:544:22
|
544 | if caplen >= std::u32::MAX - 4 {
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `-D clippy::legacy-numeric-constants` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::legacy_numeric_constants)]`
help: use the associated constant instead
|
544 | if caplen >= u32::MAX - 4 {
| ~~~~~~~~
```
* adds coverage for --all-features * adds coverage for --no-default-features
cpu
commented
Apr 10, 2024
cpu
commented
Apr 10, 2024
chifflier
approved these changes
Apr 10, 2024
|
@chifflier If you want to leave this un-merged I can push an update to add the matrix config from asn1-rs later tonight after I'm finished work. Otherwise I'll follow-up in a separate PR. Thanks! |
Sure, you can push the commit to this PR. I'll wait so you do not need to open a new one. |
Adopts a similar feature matrix approach as the asn1-rs CI. `cargo test` will be run for no default features, default features, and all features. The asn1-rs matrix differs only by having a separate "no std" job that uses `--no-default-features`. Since this crate doesn't offer a std feature we roll this step into the same matrix as the other feature configs.
Done ☑️ |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the CI standardization and refresh started in rusticata/rusticata-macros#8