Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of optional TaggedImplicit object #42

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

yestyle
Copy link
Contributor

@yestyle yestyle commented Jul 21, 2024

No description provided.

@yestyle yestyle force-pushed the opt-tagged-implicit branch from b6457c9 to 181aa81 Compare July 21, 2024 13:34
@yestyle yestyle force-pushed the opt-tagged-implicit branch from 181aa81 to 00de85f Compare July 21, 2024 13:45
@yestyle
Copy link
Contributor Author

yestyle commented Jul 21, 2024

Sorry, not familiar with TaggedParser and OptTaggedParser. Had to drop it from the test.

@chifflier chifflier self-assigned this Jul 30, 2024
@chifflier
Copy link
Member

Hi, after review, I can confirm the problem in the serialization of TaggedValue<Implicit>. Thank you for your bug report, and the PR!
I am looking for the other APIs and will commit this before a new release.

@chifflier chifflier merged commit 41d59e3 into rusticata:master Jul 30, 2024
13 checks passed
@chifflier
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants