Update cargo-check-external-types rustc version #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream project cut a 0.1.12 release that now pins Rust nightly-2024-05-01. This commit updates CI to match.
chifflier
added a commit
that referenced
this pull request
Jun 14, 2024
|
Hi, |
|
Applied, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 As promised, when
cargo-check-external-typesmakes an update I'm opening PRs to fix the builds :-)Note: there seems to be another unrelated breakage with nightly clippy, a finding from unexpected-cfgs. I'm not sure what the right fix is in this case: it seems like "exact_size_is_empty" is being used as a feature gate for the unstable nightly feature (rust-lang/rust#35428) and I'm not sure how to square that requirement with the new lint. Suggestions welcome!