Support infinite far planes #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infinite far planes is a standard trick that actually improves the precision of the Z buffer. See for instance https://thxforthefish.com/posts/reverse_z/
aloucks
reviewed
Oct 27, 2024
| @@ -220,12 +230,20 @@ impl<S: BaseFloat> From<Perspective<S>> for Matrix4<S> { | |||
|
|
|||
| let c2r0 = (persp.right + persp.left) / (persp.right - persp.left); | |||
| let c2r1 = (persp.top + persp.bottom) / (persp.top - persp.bottom); | |||
| let c2r2 = -(persp.far + persp.near) / (persp.far - persp.near); | |||
| let c2r2 = if persp.far.is_finite() { | |||
| (persp.far + persp.near) / (persp.near - persp.far) | |||
aloucks
reviewed
Oct 27, 2024
| let c2r3 = -S::one(); | ||
|
|
||
| let c3r0 = S::zero(); | ||
| let c3r1 = S::zero(); | ||
| let c3r2 = -(two * persp.far * persp.near) / (persp.far - persp.near); | ||
| let c3r2 = if persp.far.is_finite() { | ||
| (two * persp.far * persp.near) / (persp.near - persp.far) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infinite far planes is a standard trick that actually improves the precision of the Z buffer.
See for instance https://thxforthefish.com/posts/reverse_z/ and https://developer.nvidia.com/content/depth-precision-visualized