Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon/logo and html_root_url for docs #147

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

ian-h-chamberlain
Copy link
Member

Oop, was gonna add this to #146 but @Meziu was too quick for me and merged it already! I think this is probably the last polish I'll add to github pages for now.

@Meziu
Copy link
Member

Meziu commented Nov 27, 2023

Welp, I had a small change as well to add in #148. Maybe I should take a bit of time before merging 😅.

@ian-h-chamberlain ian-h-chamberlain merged commit 1c0c055 into master Nov 27, 2023
4 checks passed
@ian-h-chamberlain ian-h-chamberlain deleted the fix/docs-github-pages-followup branch November 27, 2023 16:46
@ian-h-chamberlain
Copy link
Member Author

Confirmed the html_root_url works correctly by redeploying citro3d docs:

https://rust3ds.github.io/citro3d-rs/crates/citro3d/render/enum.ColorFormat.html#impl-From%3CFramebufferFormat%3E-for-ColorFormat

Previously there was no link on FrameBufferFormat but now it links correctly to the ctru docs, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants