macOS: Fix crash when pressing Caps Lock #4024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events emitted by `flagsChanged:` cannot access `charactersIgnoringModifiers`. We were previously doing this because we were trying to re-use the `create_key_event` function. It is unsuited for this purpose, however, so now the `flagsChanged:` logic is separate from it.
madsmtm
force-pushed
the
madsmtm/fix-caps-lock
branch
from
38510ae to
17d4012
Compare
kchibisov
approved these changes
Dec 3, 2024
kchibisov
pushed a commit
that referenced
this pull request
Dec 16, 2024
Events emitted by `flagsChanged:` cannot access `charactersIgnoringModifiers`. We were previously doing this because we were trying to re-use the `create_key_event` function, but that is unsuited for this purpose, so I have separated the `flagsChanged:` logic out from it.
kchibisov
pushed a commit
that referenced
this pull request
Dec 16, 2024
Events emitted by `flagsChanged:` cannot access `charactersIgnoringModifiers`. We were previously doing this because we were trying to re-use the `create_key_event` function, but that is unsuited for this purpose, so I have separated the `flagsChanged:` logic out from it.
kchibisov
pushed a commit
that referenced
this pull request
Dec 21, 2024
Events emitted by `flagsChanged:` cannot access `charactersIgnoringModifiers`. We were previously doing this because we were trying to re-use the `create_key_event` function, but that is unsuited for this purpose, so I have separated the `flagsChanged:` logic out from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events emitted by
flagsChanged:cannot accesscharactersIgnoringModifiers. We were previously doing this because we were trying to re-use thecreate_key_eventfunction, but that is unsuited for this purpose, so I have separated theflagsChanged:logic out from it.There is still more work needed here to actually report
NamedKey::CapsLockto user code, but I've started with this to keep the diff smaller if backporting tov0.30.6.Fixes alacritty/alacritty#8268.
changelogmodule if knowledge of this change could be valuable to users