Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On macOS, fix deadlock during nested event loops (e.g. rfd) #3188

Merged
merged 2 commits into from
Oct 25, 2023
Merged

On macOS, fix deadlock during nested event loops (e.g. rfd) #3188

merged 2 commits into from
Oct 25, 2023

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Oct 25, 2023

Calling have_callback() during the callback deadlocks. Reorder the get_in_callback() call first to avoid the deadlock.

Fixes: #3179

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@jpnurmi jpnurmi requested a review from madsmtm as a code owner October 25, 2023 14:42
@kchibisov kchibisov added this to the Version 0.29.3 milestone Oct 25, 2023
@kchibisov kchibisov merged commit f4e71a1 into rust-windowing:master Oct 25, 2023
50 checks passed
@jpnurmi jpnurmi deleted the macos-rfd branch October 25, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchibisov kchibisov kchibisov approved these changes

@madsmtm madsmtm Awaiting requested review from madsmtm

Assignees
No one assigned
Labels
None yet
Milestone
Version 0.29.3
Development

Successfully merging this pull request may close these issues.

Regression: RFD file dialogs hang on macOS
2 participants
@jpnurmi @kchibisov