Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Orbital, fix window resize. #200

Merged
merged 1 commit into from
Feb 10, 2024
Merged

On Orbital, fix window resize. #200

merged 1 commit into from
Feb 10, 2024

Conversation

jackpot51
Copy link
Member

Previously it tested if both the width AND height were changed before updating the size when it should update if width OR height were changed.

@jackpot51 jackpot51 self-assigned this Feb 10, 2024
@jackpot51 jackpot51 requested a review from john01dav as a code owner February 10, 2024 04:05
@jackpot51 jackpot51 requested review from notgull and removed request for john01dav February 10, 2024 04:06
notgull
notgull approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows error looks unrelated. Maybe it's the new Clippy dead code detector?

@jackpot51 jackpot51 merged commit 2b44e7a into master Feb 10, 2024
35 of 39 checks passed
@jackpot51 jackpot51 deleted the fix-orbital-resize branch February 10, 2024 15:58
@notgull notgull mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees

@jackpot51 jackpot51

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackpot51 @notgull