-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3.1 #141
v0.3.1 #141
Conversation
I have no idea what's going on with the link errors for the Windows CI; I guess some testing there is warranted before a release, though I'm not currently booted into Windows... |
CHANGELOG.md
Outdated
* DRM/KMS backend | ||
* Use `MAP_SHARED` on Redox; fixing behavior with latest Orbital | ||
* `OffscreenCanvas` support in web backend | ||
* Error instead of segfault on macOS if size isn't set | ||
* Make `fetch` error on Windows, where it wasn't working correctly | ||
* Implement `Error` trait for `SoftBufferError` | ||
* Dependency updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that some of these lines are useful as commit messages for us as developers, but as less useful as changes for users. For instance:
* DRM/KMS backend
Should probably be something more like:
* Add support for using `softbuffer` on raw TTYs, using the DRM/KMS interface.
Also, it would be nice if these entries were accompanied by PR numbers where applicable.
I'll look into the Windows errors |
Any updates on this? |
It looks like #142 isn't really related to softbuffer, so that probably doesn't block a release... May be better to release before merging #149, since winit will still be using 0.30 (pending Smithay/client-toolkit#403, etc.) |
I agree. @notgull what do you think, can we do a release if the windows issue is not a regression? |
I'm fine with it. |
Softbuffer is broken on recent builds of Redox without the fix here, so it's helpful to have a new release that fixes it. We seem to have accumulated a few non-breaking fixes, so it seems like a good enough time to do a release anyway. Disabling `fetch` on Windows could be considered breaking, but it doesn't change the API, was broken anyway, and is likely unused. So I don't think that's an issue.
c8947e6
to
e145d47
Compare
@ids1024 are you able to tag/publish a release? |
I already released on crates.io. I hadn't thought to tag a release on Github, but I've done that now. |
Softbuffer is broken on recent builds of Redox without the fix here, so it's helpful to have a new release that fixes it. We seem to have accumulated a few non-breaking fixes, so it seems like a good enough time to do a release anyway.
Disabling
fetch
on Windows could be considered breaking, but it doesn't change the API, was broken anyway, and is likely unused. So I don't think that's an issue.