Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.1 #141

Merged
merged 1 commit into from
Sep 9, 2023
Merged

v0.3.1 #141

merged 1 commit into from
Sep 9, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Aug 27, 2023

Softbuffer is broken on recent builds of Redox without the fix here, so it's helpful to have a new release that fixes it. We seem to have accumulated a few non-breaking fixes, so it seems like a good enough time to do a release anyway.

Disabling fetch on Windows could be considered breaking, but it doesn't change the API, was broken anyway, and is likely unused. So I don't think that's an issue.

@ids1024 ids1024 requested a review from john01dav as a code owner August 27, 2023 23:42
@ids1024
Copy link
Member Author

ids1024 commented Aug 27, 2023

I have no idea what's going on with the link errors for the Windows CI; I guess some testing there is warranted before a release, though I'm not currently booted into Windows...

CHANGELOG.md Outdated
Comment on lines 3 to 9
* DRM/KMS backend
* Use `MAP_SHARED` on Redox; fixing behavior with latest Orbital
* `OffscreenCanvas` support in web backend
* Error instead of segfault on macOS if size isn't set
* Make `fetch` error on Windows, where it wasn't working correctly
* Implement `Error` trait for `SoftBufferError`
* Dependency updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that some of these lines are useful as commit messages for us as developers, but as less useful as changes for users. For instance:

* DRM/KMS backend

Should probably be something more like:

* Add support for using `softbuffer` on raw TTYs, using the DRM/KMS interface.

Also, it would be nice if these entries were accompanied by PR numbers where applicable.

@notgull
Copy link
Member

notgull commented Aug 28, 2023

I'll look into the Windows errors

@jackpot51
Copy link
Member

Any updates on this?

@ids1024
Copy link
Member Author

ids1024 commented Sep 8, 2023

It looks like #142 isn't really related to softbuffer, so that probably doesn't block a release...

May be better to release before merging #149, since winit will still be using 0.30 (pending Smithay/client-toolkit#403, etc.)

@jackpot51
Copy link
Member

I agree. @notgull what do you think, can we do a release if the windows issue is not a regression?

@ids1024
Copy link
Member Author

ids1024 commented Sep 8, 2023

#150 could be good to get in the release, if @daxpedda thinks that PR is good. (The Web backend is probably the one I'm least familiar with.)

@daxpedda
Copy link
Member

daxpedda commented Sep 8, 2023

#150 could be good to get in the release, if @daxpedda thinks that PR is good. (The Web backend is probably the one I'm least familiar with.)

Indeed, would be nice to wait for that, I'm reviewing it as we speak.

@notgull
Copy link
Member

notgull commented Sep 8, 2023

I agree. @notgull what do you think, can we do a release if the windows issue is not a regression?

I'm fine with it.

Softbuffer is broken on recent builds of Redox without the fix here, so
it's helpful to have a new release that fixes it. We seem to have
accumulated a few non-breaking fixes, so it seems like a good enough
time to do a release anyway.

Disabling `fetch` on Windows could be considered breaking, but it
doesn't change the API, was broken anyway, and is likely unused. So I
don't think that's an issue.
@ids1024 ids1024 merged commit fff761c into master Sep 9, 2023
@ids1024 ids1024 deleted the release-0.3.1 branch September 9, 2023 23:40
@jackpot51
Copy link
Member

@ids1024 are you able to tag/publish a release?

@ids1024
Copy link
Member Author

ids1024 commented Sep 10, 2023

I already released on crates.io. I hadn't thought to tag a release on Github, but I've done that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants