Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create vm-vcpu-ref crate #182

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Conversation

andreeaflorescu
Copy link
Member

This is going to be eventually published to crates.io. This is the crate
that we're using for upstreaming building blocks for setting up the vm
and vcpu for booting.

For now it lives in vmm-reference, but we are considering moving it to
its own worspace at some point in time.

@andreeaflorescu
Copy link
Member Author

We still need to figure out how we're going to handle testing for this crate. It should be tested as part of vmm-reference, but I think it also makes sense to have its own pipeline so that we can get a feeling of how many lines we're covering here to make sure we keep the same quality bar as for other crates released from rust-vmm.

@andreeaflorescu
Copy link
Member Author

We still need to figure out how we're going to handle testing for this crate. It should be tested as part of vmm-reference, but I think it also makes sense to have its own pipeline so that we can get a feeling of how many lines we're covering here to make sure we keep the same quality bar as for other crates released from rust-vmm.

We can test it using the rust-vmm-ci. I added a separate commit for this configuration. Before we can run the test though we need to fix rust-vmm/rust-vmm-ci#95.

This is going to be eventually published to crates.io. This is the crate
that we're using for upstreaming building blocks for setting up the vm
and vcpu for booting.

For now it lives in vmm-reference, but we are considering moving it to
its own worspace at some point in time.

Signed-off-by: Andreea Florescu <[email protected]>
This is created as a symlink so we don't need to have another submodule
to maintain. This was we only need to update rust-vmm-ci in one place.

Also, having rust-vmm-ci in vm-vcpu-ref is needed so we can test this as
a separate crate within the workspace. Not all features that we'll add
to vm-vcpu-ref are going to necessarily be used by vmm-reference, so we
could have specialized tests only for vm-vcpu-ref. Also, for publishing
we would like to know what is the coverage of the crate.

For the coverage test to be able to run only for vm-vcpu-ref, we also
need to include this crate in the global workspace.

Signed-off-by: Andreea Florescu <[email protected]>
b037be3 update test_coverage to allow running it on crates

Signed-off-by: Andreea Florescu <[email protected]>
@lauralt lauralt merged commit 4bbedc4 into rust-vmm:main Nov 2, 2021
@andreeaflorescu andreeaflorescu deleted the setup_vm_vcpu_ref branch November 2, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants