Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vhost vdpa: expose device to container #65

Closed
wants to merge 1 commit into from

Conversation

alxiord
Copy link
Member

@alxiord alxiord commented Jun 2, 2021

This PR exposes the /dev/vhost-vdpa-0 device to the test container, to unblock testing vhost-vdpa support properly (see rust-vmm/vhost#33).

Do not merge until the CI images are upgraded so that the /dev/vhost-vdpa-0 device exists on the host.

#64

Fixes rust-vmm#64

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
@andreeaflorescu
Copy link
Member

I think we might need to take a step back and think about how we want to support this in the future. It looks a bit odd to need to make the rust-vmm-ci device specific. What I have in mind is maybe thinking about the possibility for the rust-vmm-ci pipeline to be configurable, allowing the individual CIs to set additional parameters somehow.

Depending on how hard that might actually be, we can take the shortcut in this PR temporarily.

@andreeaflorescu
Copy link
Member

This is no longer needed because we're adding the changes in vhost directly. We still need to figure out a nicer way to pass custom configurations to rust-vmm-ci. I'll open a separate issue for that.

@alxiord alxiord deleted the vdpa branch June 7, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants