Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update container version to v48 #174

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ShadowCurse
Copy link
Collaborator

@ShadowCurse ShadowCurse commented Dec 10, 2024

Summary of the PR

Update container version to v48

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@TimePrinciple
Copy link
Contributor

TimePrinciple commented Dec 10, 2024

Shouldn't the version be of v48 in the title 😮

roypat
roypat previously approved these changes Dec 10, 2024
@roypat roypat changed the title chore: update container version to v47 chore: update container version to v48 Dec 10, 2024
@roypat
Copy link
Collaborator

roypat commented Dec 10, 2024

Shouldn't the version be of v48 in the title 😮

yes haha

@stefano-garzarella
Copy link
Member

Shouldn't the version be of v48 in the title 😮

Yep, @ShadowCurse please update it in the commit title too.

Copy link
Member

@stefano-garzarella stefano-garzarella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please next time put something in the commit description, like new features/fix or link to the PRs included in the new container version.
See cdb4a2d as an example.

@ShadowCurse ShadowCurse merged commit 09aef99 into rust-vmm:main Dec 10, 2024
3 checks passed
@ShadowCurse ShadowCurse deleted the docker_update branch December 10, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants