Enable rust-vmm coverage test in CI

[MrXinWang]

Referencing discussion in kvm-ioctls/issue#9 and issue#10, proposing a draft PR for enabling coverage test on arm64.

I think we also need to rename the old coverage path file in each repository to avoid misunderstanding. What do you think @andreeaflorescu ?

Signed-off-by: Henry Wang <[email protected]>

[andreeaflorescu]

Temporarily blocking this until we have the kcov patches merged upstream.

Related to the actual changes: the problem that I see is that some crates don't really have arm support. So even though you don't support arm, you would still need to have the coverage file for both platforms. I am wondering if we can configure this somehow per crate.

I can maybe look into this early next week because right now I am attending a conference and don't really have a lot of spare cycles.

[MrXinWang]

Updated the commit to fix #6

I think I also need to update the new pipeline.yml to fully enable the coverage test (after kcov is under the new release and the docker image is updated)?

[andreeaflorescu]

@MrXinWang I published a new version of rust-vmm-container (v5). I will check how your PR works with kvm-ioctls and I will dismiss my review so we can merge this one.

[MrXinWang]

@andreeaflorescu Thanks very much for that. I remember from our last discussion we also need to upload the coverage.json file for aarch64 to seperate the x86_64 and arm64 coverage files.

[andreeaflorescu]

We should also update the Buildkite pipeline to use rustvmm/dev:v5 because that is the version that contains the kcov fix on aarch64.

[MrXinWang]

@andreeaflorescu yes sure. I will upload a commit together with the coverage file thing after you are happy with every change in this PR :)

[andreeaflorescu]

@andreeaflorescu yes sure. I will upload a commit together with the coverage file thing after you are happy with every change in this PR :)

To recap, to merge this we need to do the following:

• create 2 example coverage files that should replace the current coverage_config.json.sample. This should be named coverage_config_x86_64.json.sample and coverage_config_aarch64.json.sample so that people can just remove the sample suffix and use them as an example.
• Update the README.md to specify that we now have 2 coverage files, one per each platform. The section that needs to be updated is ## Getting Started with rust-vmm-ci, bullet 2.
• update the Buildkite pipeline to use rust-vmm/dev:v5

I hope I am not missing anything. After these changes are address, we can merge the PR.

[MrXinWang]

@andreeaflorescu Thanks for the recap. I think I have updated all of them, also changed the container version used in README.md from v3 to v5. Please review.

[MrXinWang]

@andreeaflorescu I am sorry but do we both missed the one of the most important thing: add another pipeline in Buildkite for arm coverage test...? I have updated the code, now it looks ok to me.

- label: "coverage-arm"
    commands:
      - pytest rust-vmm-ci/integration_tests/test_coverage.py
    retry:
      automatic: false
    agents:
      platform: arm.metal
      os: linux
    plugins:
      - docker#v3.0.1:
          privileged: true
          image: "rustvmm/dev:v5"
          always-pull: true

[andreeaflorescu]

@MrXinWang hahaha yap, we totally missed that.