RFC: Drop hash table for per-element attributes for more compact sorted vector #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
force-pushed
the
sorted-vec-instead-of-hash-table
branch
from
f589f17 to
03e329b
Compare
|
The branch is based off #220. |
adamreichold
force-pushed
the
sorted-vec-instead-of-hash-table
branch
from
03e329b to
ee66ee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at our
indexmapdependency, I wondered whether a hash table per element is not too heavy weight for what we are doing. For looking up attributes by name, we can also use a sorted list to get O(log n) instead O(<1>) which considering the typical number of attributes on an element should be good enough. Similarly, adding attributes one-by-one after the fact should be rare, so shuffling them around should be rare as well. What this yields is a more compact representation and simpler machine code (even though the source code gets a bit messier).