Add a binding for pcap_loop #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stargateur
suggested changes
Oct 5, 2023
| self.handle.as_ptr(), | ||
| 0, | ||
| Handler::<F>::callback, | ||
| ptr::addr_of_mut!(handler).cast(), |
There was a problem hiding this comment.
I think it's fine but not sure.
There was a problem hiding this comment.
I'm not sure what you mean to comment on here. Perhaps you mean ptr::addr_of_mut!? If the place it's passed has no projections, then there are no preconditions. And you can even addr_of!(*ptr) for any ptr: rust-lang/reference#1387
src/lib.rs
Outdated
| impl<T: State + ?Sized> Capture<T> { | ||
| pub fn pcap_loop<F>(&mut self, handler: F) |
There was a problem hiding this comment.
this method is unsafe by nature, since it's will call rust from C
|
Due to significant changes on |
|
sigh I force-pushed to the branch before re-opening the PR which has killed the PR. I'll open a fresh one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into a situation where a tool I help maintain and
tcpdumphad different behavior with a somewhat exotic libpcap implementation. I eventually tracked this down to the fact thattcpdumpusespcap_loopand since said tool is going through this crate, it was usingpcap_next_ex. This difference was actually a bug in the libpcap implementation, I spent a frustrating amount of time convincing people that the bug was in libpcap, because I couldn't closely imitate the libpcap calls oftcpdump.Since that time, I've been wanting a way to call
pcap_loopfrom this crate, because that would have made my life a lot easier. So I finally got around to putting one together, here it is.I don't really care about the public API. Ideas like a better name are very welcome.