-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD support #49
FreeBSD support #49
Conversation
@ydirson Please fix the CI failure. Meanwhile, please include https://github.com/rust-netlink/netlink-packet-route/blob/main/.github/workflows/build.yml to this PR, so we know this project can actually compile on FreeBSD. (You may only keep Thank you! |
The libc support still has not been merged, so this will not build yet out of the fox on freebsd. Things more very slowly there, but it's not clear if I should resubmit my patch for 0.2 instead but protected by a feature flag. |
I'm unsure how to handle examples that can only build under a given I tried guarding the example code with |
Instead of |
Not supported there. Signed-off-by: Yann Dirson <[email protected]>
Not supported there. Signed-off-by: Yann Dirson <[email protected]>
I'm not really happy with the readability, there ought to be a real way to mark an example as "non applicable in cfg so and so". Signed-off-by: Yann Dirson <[email protected]>
Done - that had to be |
@ydirson The 0.14.1 release contains this PR now. Thanks for the contribution! |
rtnetlink has 2 problems building on FreeBSD:
AddressFamily::Bridge
innetlink-packet-route
, addressed in second commitI originally thought about hiding namespaces and traffic control behind a
ns
feature, what do you think?That second point brings me back to my original suggestion of having enum values defined once, regardless of target platform support.