Update to nix 0.27.1 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cathay4t, do you mind taking a quick look at this? We need the upgrade as well. Thanks! |
|
The upgrade is needed for LoongArch support. |
|
Also would love to see this. @JohnTitor is another maintainer of this repo (I believe) and may be able to move it forward, if they have a moment? |
JohnTitor
approved these changes
Nov 22, 2023
|
Thanks! Much appreciated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nix 0.27 now uses the OwnedFd/BorrowedFd API from Rust 1.63.
The
setnscall needs a BorrowedFd, while we only have a raw fd. We could either create a OwnedFd or a BorrowedFd from the open done inunshare_processing, but the OwnedFd would close on drop, while there is no close in the current code, so I simply created a BorrowedFd on the fly. I'm not sure whether the missing close is a bug or not.