Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustup: reactivate myself #1610

Closed
wants to merge 2 commits into from
Closed

rustup: reactivate myself #1610

wants to merge 2 commits into from

Conversation

Rustin170506
Copy link
Member

ref #1035 (comment)

cc @rust-lang/rustup

@Rustin170506
rustup: reactivate myself
bb5fe87 
Signed-off-by: Rustin170506 <[email protected]>
rami3l
rami3l approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back :)

@Rustin170506
fix: update my email as well
59fcf57 
Signed-off-by: Rustin170506 <[email protected]>
@rylev
Copy link
Member

rylev commented Nov 19, 2024

r? @rbtcollins

@djc
Copy link
Contributor

djc commented Nov 19, 2024

Personally given that the (active) team is all different, I think it would be nice if you spend some time contributing (again) before you formally rejoin the team.

@Rustin170506
Copy link
Member Author

Rustin170506 commented Nov 19, 2024 •
edited
Loading

Personally given that the (active) team is all different, I think it would be nice if you spend some time contributing (again) before you formally rejoin the team.

@djc I have already started trying to help:

  1. Cannot install toolchain if preceding option uses comma separated list as an argument rustup#4073 (comment)
  2. Upgrade to rustls-platform-verifier 0.4 rustup#4087 (review)
  3. feat: align website style with www.rust-lang.org for consistency rustup#4080
  4. Use indicatif as the progress bar rustup#3349

May I ask what specific concerns you have here? (Just want to check if anything I can do to solve your concerns)

@djc
Copy link
Contributor

djc commented Nov 19, 2024 •
edited
Loading

Personally given that the (active) team is all different, I think it would be nice if you spend some time contributing (again) before you formally rejoin the team.

@djc I have already started trying to help:

  1. Cannot install toolchain if preceding option uses comma separated list as an argument rustup#4073 (comment)
  2. Upgrade to rustls-platform-verifier 0.4 rustup#4087 (review)
  3. feat: align website style with www.rust-lang.org for consistency rustup#4080
  4. Use indicatif as the progress bar rustup#3349

May I ask what specific concerns you have here? (Just want to check if anything I can do to solve your concerns)

Yes, I'm aware of those! I appreciate the efforts but I'd personally like to see how you respond to feedback and if you have any useful feedback during reviews (which is hard to tell from a LGTM comment). Given that you can already review and contribute PRs, and given that we don't currently have a shortage of reviewing capacity, I don't think there is any urgency to adding new team members.

@Rustin170506
Copy link
Member Author

Rustin170506 commented Nov 19, 2024 •
edited
Loading

I’m a bit sad that I lost that trust, but I’m okay with it.

@Rustin170506 Rustin170506 deleted the rustin-patch-rustup branch November 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rustin170506 @rylev @djc @rami3l