Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge-bots configuration per branch protection #1576

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Oct 11, 2024

Instead of just assuming that when bors (homu) is enabled for a repository, all its branches will be automatically managed by it, this PR adds an opt-in mechanism to use bors/homu for specific branch protections.

Instead of just assuming that when bors (homu) is enabled for a repository, all its repositories will be automatically managed by it, this PR adds an opt-in mechanism to use bors/homu for specific branch protections.
@MarcoIeni
Copy link
Member

MarcoIeni commented Nov 19, 2024

all its repositories will be automatically managed by it

What do you mean?

A repo doesn't have multiple repositories.
Do you mean "branches"?

@Kobzol
Copy link
Contributor Author

Kobzol commented Nov 19, 2024

Yes, I indeed meant branches, sorry =D

This PR shouldn't have any user-facing changes, so hopefully should be relatively safe. Once it lands, I'll change sync-team to read bors permissions from the branch protection instead from the array of bots. That should also be safe, because there is currently no repository in team that is managed by homu xD

@Kobzol Kobzol marked this pull request as ready for review November 19, 2024 08:40
@MarcoIeni MarcoIeni merged commit 012c44a into rust-lang:master Nov 19, 2024
1 check passed
@MarcoIeni
Copy link
Member

Merged because it only changes the schema and code 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants