Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added visionOS support for Apple Vision Pro #514

Closed
wants to merge 4 commits into from
Closed

feat: Added visionOS support for Apple Vision Pro #514

wants to merge 4 commits into from

Conversation

eugenehp
Copy link

@eugenehp eugenehp commented Jun 4, 2024

Saw good work in #503

This PR addresses the comments with target_os specifics.

Tested it with Tier 3 target.

@eugenehp eugenehp mentioned this pull request Jun 4, 2024
Open
9 tasks
@eugenehp eugenehp changed the title added visionos support feat: Added visionOS support for Apple Vision Pro Jun 4, 2024
@eugenehp
Copy link
Author

eugenehp commented Jun 4, 2024

CI pulls old nightly from 2018, should pull the recent one instead,

Screenshot 2024-06-04 at 10 29 23 AM

@eugenehp
Copy link
Author

eugenehp commented Jun 4, 2024

Looks like CI for freebsd is broken
The resource 'projects/freebsd-org-cloud-dev/global/images/family/freebsd-13-2' was not found

Thomasdezeeuw
Thomasdezeeuw reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is not ok.

You mention #503, but then proceed to not give the author credit.

You also remove another OS from the CI?

I'm sorry, but this is just unacceptable.

Closing in favour of #503.

.github/workflows/main.yml
@@ -56,7 +56,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target: ["aarch64-apple-ios", "aarch64-linux-android", "x86_64-apple-darwin", "x86_64-unknown-fuchsia", "x86_64-pc-windows-msvc", "x86_64-pc-solaris", "x86_64-unknown-freebsd", "x86_64-unknown-illumos", "x86_64-unknown-linux-gnu", "x86_64-unknown-linux-musl", "x86_64-unknown-netbsd", "x86_64-unknown-redox", "armv7-linux-androideabi", "i686-linux-android"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. That's not happening.

Why would you delete an OS in a pr to add another?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#514 (comment)

@eugenehp
Copy link
Author

eugenehp commented Jun 5, 2024

This pr is not ok.

You mention #503, but then proceed to not give the author credit.

This code was done without prior knowledge of #503

You also remove another OS from the CI?

#514 (comment)

I'm sorry, but this is just unacceptable.

Ok, let me know if I can be of help with #503. Thanks.

Closing in favour of #503.

@Thomasdezeeuw
Copy link
Collaborator

You also remove another OS from the CI?

#514 (comment)

The solution is not to remove another OS, especially not within a pr that adds another.

Why not communicate with the maintainers, i.e. me, on how to solve it?

I'm sorry, but this is just unacceptable.

Ok, let me know if I can be of help with #503. Thanks.

You can leave this patch on that pr so we can further discuss adding visionOS support.

@eugenehp
Copy link
Author

eugenehp commented Jun 5, 2024

Thanks Thomas, didn't mean to offend with that commit, was just testing what's wrong with the CI. We've freebsd in production too.
I'll take a look at the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eugenehp @Thomasdezeeuw