Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(user-guide/components): add deprecation notice for wasm32-wasi #4149

Merged
merged 2 commits into from
Jan 10, 2025
Merged

docs(user-guide/components): add deprecation notice for wasm32-wasi #4149

merged 2 commits into from
Jan 10, 2025

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jan 10, 2025

Partially addresses #4099.

@rami3l rami3l requested review from djc and ChrisDenton January 10, 2025 01:43
ChrisDenton
ChrisDenton approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever else we, do this looks like a start. It would be good to have some upstream support for renames but I guess it's a very rare occurrence.

@rami3l rami3l enabled auto-merge January 10, 2025 03:29
@rami3l rami3l added this pull request to the merge queue Jan 10, 2025
Merged via the queue into master with commit 6fa21c2 Jan 10, 2025
27 checks passed
@rami3l rami3l deleted the rami3l-patch-1 branch January 10, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton approved these changes

@djc djc Awaiting requested review from djc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rami3l @ChrisDenton