-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hint which style_edition to use instead of version #6361
Hint which style_edition to use instead of version #6361
Conversation
Use `style_edition=\"{0}\"` instead.", | ||
match self.version.2 { | ||
Version::One => "2015", | ||
Version::Two => "2024", | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version=One
is equivalent to 2015
, 2018
, or 2021
. Do you think it would be useful to be a little more specific in the warning message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly there is no difference between using 2015
, 2018
or 2021
so I think it should be fine to give the "default" value as an hint in the warning, given that following it will give you the desired behavior. It could maybe useful to mention it in the docs so to not have to look it up in the tracking issue.
If we do that should the style_version=2027
also be added as an alternative for 2024
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioning it in the docs sounds good to me, and we can leave the warning message recommending the default value of 2015. We definitely don't want to recommend style_version=2027
as an alternative for 2024 since 2024 will be stabilized soon and 2027 is going to remain an unstable variant for now.
3de0653
to
1db47e9
Compare
1db47e9
to
ba4552c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping out on this one and including the style_edition
details in the warning message and docs
To resolve #6340.
Did not add too many information as to maintain succinct the warnings. I don't know if a link to relevant info in the warning would be useful.