Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shallow clone in test.rs to reduce cloning overhead #432

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

tempdragon
Copy link
Contributor

GitHub may not necessarily be accessible in some conditions/locations. Switching to a shallow clone can significantly reduce the time for cloning rust from GitHub.

@tempdragon tempdragon changed the title Use shallow clone in test.rs to improve Use shallow clone in test.rs to reduse cloning overhead Feb 13, 2024
@tempdragon tempdragon changed the title Use shallow clone in test.rs to reduse cloning overhead Use shallow clone in test.rs to reduce cloning overhead Feb 13, 2024
@tempdragon tempdragon force-pushed the master branch 3 times, most recently from d649e0a to 4f84385 Compare February 13, 2024 15:30
@tempdragon tempdragon requested a review from bjorn3 February 13, 2024 15:49
@GuillaumeGomez
Copy link
Member

I remember having issues when doing shallow clones. However I can't figure which ones. Let's get this in for now and if issues arise, we can always revert. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 79c8780 into rust-lang:master Feb 17, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants