Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from actions-rs to preinstalled rustup #412

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jan 12, 2024

actions-rs is deprecated. Switch to using the preinstalled rustup to install the toolchain, and https://github.com/Swatinem/rust-cache to configure cacheing.

https://github.com/dtolnay/rust-toolchain cannot be used because it does not respect rust-toolchain.

I believe there isn't any need to run cargo build separately anymore since there are no longer error annotations.

Fixes #381

@tgross35
Copy link
Contributor Author

@antoyo does matrix items libgccjit_version or commands (link) affect what is built? If so, maybe they should be part of the cache key

@antoyo
Copy link
Contributor

antoyo commented Jan 12, 2024

@antoyo does matrix items libgccjit_version or commands (link) affect what is built? If so, maybe they should be part of the cache key

No, rustc_codegen_gcc itself is built with LLVM, so the crates used by it are not affected by those flags.

@antoyo
Copy link
Contributor

antoyo commented Jan 12, 2024

It seems like you forgot to remove actions-rs in the gcc12 CI.

actions-rs is deprecated. Switch to using the preinstalled rustup to install
the toolchain, and https://github.com/Swatinem/rust-cache to configure
cacheing.
@tgross35
Copy link
Contributor Author

Good catch, removed that

@antoyo antoyo merged commit 1a8e0c3 into rust-lang:master Jan 12, 2024
32 checks passed
@antoyo
Copy link
Contributor

antoyo commented Jan 12, 2024

Thanks a lot!

@tgross35 tgross35 deleted the gha-update branch January 12, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: move away from actions-rs
2 participants