Extend ptr::null and null_mut to all thin (including extern) types #94954

SimonSapin · 2022-03-15T09:33:06Z

This change was accepted in https://rust-lang.github.io/rfcs/2580-ptr-meta.html

Note that this changes the signature of stable functions. The change should be backward-compatible, but it is insta-stable since it cannot (easily, at all?) be made available only through a #![feature(…)] opt-in.

The RFC also proposed the same change for NonNull::dangling, which makes sense it terms of its signature but not in terms of its implementation. dangling uses align_of() as an address. But what align_of() should be for extern types or whether it should be allowed at all remains an open question.

This commit depends on #93977, which is not yet part of the bootstrap compiler. So #[cfg] is used to only apply the change in stage 1+. As far a I know bounds cannot be made conditional with #[cfg], so the entire functions are duplicated. This is unfortunate but temporary.

Since this duplication makes it less obvious in the diff, the new definitions differ in:

More permissive bounds (Thin instead of implied Sized)
Different implementation
Having rustc_allow_const_fn_unstable(const_fn_trait_bound)
Having rustc_allow_const_fn_unstable(ptr_metadata)

rust-highfive · 2022-03-15T09:33:10Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

SimonSapin · 2022-03-15T09:49:13Z

I pushed changes to disable the new test in stage 0, but based on line numbers in the error message it looks like the second CI run did not account for these changes?

SimonSapin · 2022-03-15T11:31:38Z

src/test/ui/cast/casts-issue-46365.rs

@@ -3,5 +3,5 @@ struct Lorem {
 }

 fn main() {
-    let _foo: *mut Lorem = core::ptr::null_mut(); // no error here
+    let _foo: *mut Lorem = 0 as *mut _; // no error here


This reverts part of #61864 (which unfortunately does not give its motivation) to restore the test as originally added in https://github.com/rust-lang/rust/pull/46973/files#diff-b3ce752f21a6d94f8e4c9b0c95d41eaf2976a0e5b100ed0f86422fb1b106266f, in order to avoid an additional error message https://github.com/rust-lang/rust/runs/5552124004?check_suite_focus=true#step:26:1607 that appears unrelated to the test and #46365.

Curious: If you made a field with a known non-DST type after ipsum in Lorem, would it not get tripped up? It does seem like since ipsum is the final field, it can't derive the metadata one way or another, but otherwise it perhaps could.

With strict provenance (which I believe was added after this comment) we definitely want to keep null_mut instead of zero casts.

Would null_mut itself not be implemented with a cast under strict provenance?

null_mut defers to invalid_mut which in turn is just a cast yeah. The ideal is for everything to funnel into methods with clearer intent/semantics so that automated tooling better understands what you're trying to do and can help catch bugs (i.e. maybe invalid_mut becomes an intrinsic so the compiler can mark some metadata for other tools?)

At very least there are a few lints in the pipeline for people to opt into flagging all the places that do these bare casts as "suspicious" and worth investigating.

Also more stuff using the "right" APIs for what they want to do makes it easier for cursed platforms to do hacks. Like if someone really wanted to force Rust onto a null!=0 platform, everything going through null/null_mut/is_null makes that a lot more plausible of an officially-unsupported-but-functional-hack.

I’ve changed this file to use NonNull::dangling to preserve the spirit of the test while avoiding the unrelated error that this PR adds with null_mut at a line commented with // no error here

FWIW the original bug (#46365) was about as casts so I highly doubt that this is still testing what it was intended to test (which is a problem introduced by #61864 doing blind search-and-replace).

Opened #97765 to restore test.

Mark-Simulacrum · 2022-03-18T15:05:20Z

I'm going to r? @yaahc as a libs-api member to review and kick off FCP when ready, since this change is insta-stable.

Gankra · 2022-03-28T22:38:21Z

(this is going to merge-conflict with #95241 but the fixup will be trivial for whichever one lands second)

yaahc · 2022-03-28T23:53:53Z

@rfcbot fcp merge

This PR finishes work that began back in 2017¹ and resolves a significant ergonomic shortcoming² of extern types. This PR was opened in response to the lang team expressing interest in making progress on extern types.

yaahc · 2022-03-28T23:54:59Z

what the heck rfcbot, why hast thou forsaken me

dtolnay · 2022-03-29T00:27:10Z

@rust-lang/libs-api:
@rfcbot fcp merge

rfcbot · 2022-03-29T00:27:11Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Fixes rust-lang#93959 This change was accepted in https://rust-lang.github.io/rfcs/2580-ptr-meta.html Note that this changes the signature of **stable** functions. The change should be backward-compatible, but it is **insta-stable** since it cannot (easily, at all?) be made available only through a `#![feature(…)]` opt-in. The RFC also proposed the same change for `NonNull::dangling`, which makes sense it terms of its signature but not in terms of its implementation. `dangling` uses `align_of()` as an address. But what `align_of()` should be for extern types or whether it should be allowed at all remains an open question. This commit depends on rust-lang#93977, which is not yet part of the bootstrap compiler. So `#[cfg]` is used to only apply the change in stage 1+. As far a I know bounds cannot be made conditional with `#[cfg]`, so the entire functions are duplicated. This is unfortunate but temporary. Since this duplication makes it less obvious in the diff, the new definitions differ in: * More permissive bounds (`Thin` instead of implied `Sized`) * Different implementation * Having `rustc_allow_const_fn_unstable(ptr_metadata)`

SimonSapin · 2022-05-13T16:03:53Z

My mistake, sorry!

rfcbot · 2022-05-18T22:52:50Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

yaahc · 2022-05-24T21:11:36Z

@bors r+

bors · 2022-05-24T21:11:38Z

📌 Commit 7ccc09b has been approved by yaahc

bors · 2022-05-24T21:31:42Z

⌛ Testing commit 7ccc09b with merge 16a97d47bd8cd68c8ff28dce1fb54152f67e652b...

bors · 2022-05-24T22:32:50Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-05-24T22:45:02Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

lcnr · 2022-05-25T05:29:58Z

@bors retry

bors · 2022-05-25T13:58:55Z

⌛ Testing commit 7ccc09b with merge 9fed130...

bors · 2022-05-25T16:39:31Z

☀️ Test successful - checks-actions
Approved by: yaahc
Pushing 9fed130 to master...

rust-timer · 2022-05-25T19:24:15Z

Finished benchmarking commit (9fed130): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.1%	1.1%	3
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	4.0%	4.0%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-4.1%	-6.9%	3
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.6%	-2.6%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

RalfJung · 2022-06-05T15:53:41Z

library/core/src/ptr/mod.rs

+#[rustc_diagnostic_item = "ptr_null"]
+#[cfg(not(bootstrap))]
+pub const fn null<T: ?Sized + Thin>() -> *const T {
+    from_raw_parts(0 as *const (), ())


This should have used invalid rather than a int2ptr cast.
(The strict provenance stuff landed in between this PR here being created and landing, which I guess is why this was missed.)

Fixed in #97764

Pkgsrc changes: * Adjust patches as needed & checksum updates. Upstream changes: Version 1.63.0 (2022-08-11) ========================== Language -------- - [Remove migrate borrowck mode for pre-NLL errors.][95565] - [Modify MIR building to drop repeat expressions with length zero.][95953] - [Remove label/lifetime shadowing warnings.][96296] - [Allow explicit generic arguments in the presence of `impl Trait` args.] [96868] - [Make `cenum_impl_drop_cast` warnings deny-by-default.][97652] - [Prevent unwinding when `-C panic=abort` is used regardless of declared ABI.][96959] - [lub: don't bail out due to empty binders.][97867] Compiler -------- - [Stabilize the `bundle` native library modifier,][95818] also removing the deprecated `static-nobundle` linking kind. - [Add Apple WatchOS compile targets\*.][95243] - [Add a Windows application manifest to rustc-main.][96737] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Implement `Copy`, `Clone`, `PartialEq` and `Eq` for `core::fmt::Alignment`.][94530] - [Extend `ptr::null` and `null_mut` to all thin (including extern) types.][94954] - [`impl Read and Write for VecDeque<u8>`.][95632] - [STD support for the Nintendo 3DS.][95897] - [Make write/print macros eagerly drop temporaries.][96455] - [Implement internal traits that enable `[OsStr]::join`.][96881] - [Implement `Hash` for `core::alloc::Layout`.][97034] - [Add capacity documentation for `OsString`.][97202] - [Put a bound on collection misbehavior.][97316] - [Make `std::mem::needs_drop` accept `?Sized`.][97675] - [`impl Termination for Infallible` and then make the `Result` impls of `Termination` more generic.][97803] - [Document Rust's stance on `/proc/self/mem`.][97837] Stabilized APIs --------------- - [`array::from_fn`] - [`Box::into_pin`] - [`BinaryHeap::try_reserve`] - [`BinaryHeap::try_reserve_exact`] - [`OsString::try_reserve`] - [`OsString::try_reserve_exact`] - [`PathBuf::try_reserve`] - [`PathBuf::try_reserve_exact`] - [`Path::try_exists`] - [`Ref::filter_map`] - [`RefMut::filter_map`] - [`NonNull::<[T]>::len`][`NonNull::<slice>::len`] - [`ToOwned::clone_into`] - [`Ipv6Addr::to_ipv4_mapped`] - [`unix::io::AsFd`] - [`unix::io::BorrowedFd<'fd>`] - [`unix::io::OwnedFd`] - [`windows::io::AsHandle`] - [`windows::io::BorrowedHandle<'handle>`] - [`windows::io::OwnedHandle`] - [`windows::io::HandleOrInvalid`] - [`windows::io::HandleOrNull`] - [`windows::io::InvalidHandleError`] - [`windows::io::NullHandleError`] - [`windows::io::AsSocket`] - [`windows::io::BorrowedSocket<'handle>`] - [`windows::io::OwnedSocket`] - [`thread::scope`] - [`thread::Scope`] - [`thread::ScopedJoinHandle`] These APIs are now usable in const contexts: - [`array::from_ref`] - [`slice::from_ref`] - [`intrinsics::copy`] - [`intrinsics::copy_nonoverlapping`] - [`<*const T>::copy_to`] - [`<*const T>::copy_to_nonoverlapping`] - [`<*mut T>::copy_to`] - [`<*mut T>::copy_to_nonoverlapping`] - [`<*mut T>::copy_from`] - [`<*mut T>::copy_from_nonoverlapping`] - [`str::from_utf8`] - [`Utf8Error::error_len`] - [`Utf8Error::valid_up_to`] - [`Condvar::new`] - [`Mutex::new`] - [`RwLock::new`] Cargo ----- - [Stabilize the `--config path` command-line argument.][cargo/10755] - [Expose rust-version in the environment as `CARGO_PKG_RUST_VERSION`.][cargo/10713] Compatibility Notes ------------------- - [`#[link]` attributes are now checked more strictly,][96885] which may introduce errors for invalid attribute arguments that were previously ignored. Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Prepare Rust for LLVM opaque pointers.][94214] [94214]: rust-lang/rust#94214 [94530]: rust-lang/rust#94530 [94954]: rust-lang/rust#94954 [95243]: rust-lang/rust#95243 [95565]: rust-lang/rust#95565 [95632]: rust-lang/rust#95632 [95818]: rust-lang/rust#95818 [95897]: rust-lang/rust#95897 [95953]: rust-lang/rust#95953 [96296]: rust-lang/rust#96296 [96455]: rust-lang/rust#96455 [96737]: rust-lang/rust#96737 [96868]: rust-lang/rust#96868 [96881]: rust-lang/rust#96881 [96885]: rust-lang/rust#96885 [96959]: rust-lang/rust#96959 [97034]: rust-lang/rust#97034 [97202]: rust-lang/rust#97202 [97316]: rust-lang/rust#97316 [97652]: rust-lang/rust#97652 [97675]: rust-lang/rust#97675 [97803]: rust-lang/rust#97803 [97837]: rust-lang/rust#97837 [97867]: rust-lang/rust#97867 [cargo/10713]: rust-lang/cargo#10713 [cargo/10755]: rust-lang/cargo#10755 [`array::from_fn`]: https://doc.rust-lang.org/stable/std/array/fn.from_fn.html [`Box::into_pin`]: https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.into_pin [`BinaryHeap::try_reserve_exact`]: https://doc.rust-lang.org/stable/alloc/collections/binary_heap/struct.BinaryHeap.html#method.try_reserve_exact [`BinaryHeap::try_reserve`]: https://doc.rust-lang.org/stable/std/collections/struct.BinaryHeap.html#method.try_reserve [`OsString::try_reserve`]: https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.try_reserve [`OsString::try_reserve_exact`]: https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.try_reserve_exact [`PathBuf::try_reserve`]: https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#method.try_reserve [`PathBuf::try_reserve_exact`]: https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#method.try_reserve_exact [`Path::try_exists`]: https://doc.rust-lang.org/stable/std/path/struct.Path.html#method.try_exists [`Ref::filter_map`]: https://doc.rust-lang.org/stable/std/cell/struct.Ref.html#method.filter_map [`RefMut::filter_map`]: https://doc.rust-lang.org/stable/std/cell/struct.RefMut.html#method.filter_map [`NonNull::<slice>::len`]: https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.len [`ToOwned::clone_into`]: https://doc.rust-lang.org/stable/std/borrow/trait.ToOwned.html#method.clone_into [`Ipv6Addr::to_ipv4_mapped`]: https://doc.rust-lang.org/stable/std/net/struct.Ipv6Addr.html#method.to_ipv4_mapped [`unix::io::AsFd`]: https://doc.rust-lang.org/stable/std/os/unix/io/trait.AsFd.html [`unix::io::BorrowedFd<'fd>`]: https://doc.rust-lang.org/stable/std/os/unix/io/struct.BorrowedFd.html [`unix::io::OwnedFd`]: https://doc.rust-lang.org/stable/std/os/unix/io/struct.OwnedFd.html [`windows::io::AsHandle`]: https://doc.rust-lang.org/stable/std/os/windows/io/trait.AsHandle.html [`windows::io::BorrowedHandle<'handle>`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.BorrowedHandle.html [`windows::io::OwnedHandle`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.OwnedHandle.html [`windows::io::HandleOrInvalid`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.HandleOrInvalid.html [`windows::io::HandleOrNull`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.HandleOrNull.html [`windows::io::InvalidHandleError`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.InvalidHandleError.html [`windows::io::NullHandleError`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.NullHandleError.html [`windows::io::AsSocket`]: https://doc.rust-lang.org/stable/std/os/windows/io/trait.AsSocket.html [`windows::io::BorrowedSocket<'handle>`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.BorrowedSocket.html [`windows::io::OwnedSocket`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.OwnedSocket.html [`thread::scope`]: https://doc.rust-lang.org/stable/std/thread/fn.scope.html [`thread::Scope`]: https://doc.rust-lang.org/stable/std/thread/struct.Scope.html [`thread::ScopedJoinHandle`]: https://doc.rust-lang.org/stable/std/thread/struct.ScopedJoinHandle.html [`array::from_ref`]: https://doc.rust-lang.org/stable/std/array/fn.from_ref.html [`slice::from_ref`]: https://doc.rust-lang.org/stable/std/slice/fn.from_ref.html [`intrinsics::copy`]: https://doc.rust-lang.org/stable/std/intrinsics/fn.copy.html [`intrinsics::copy_nonoverlapping`]: https://doc.rust-lang.org/stable/std/intrinsics/fn.copy_nonoverlapping.html [`<*const T>::copy_to`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to [`<*const T>::copy_to_nonoverlapping`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to_nonoverlapping [`<*mut T>::copy_to`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to-1 [`<*mut T>::copy_to_nonoverlapping`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to_nonoverlapping-1 [`<*mut T>::copy_from`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_from [`<*mut T>::copy_from_nonoverlapping`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_from_nonoverlapping [`str::from_utf8`]: https://doc.rust-lang.org/stable/std/str/fn.from_utf8.html [`Utf8Error::error_len`]: https://doc.rust-lang.org/stable/std/str/struct.Utf8Error.html#method.error_len [`Utf8Error::valid_up_to`]: https://doc.rust-lang.org/stable/std/str/struct.Utf8Error.html#method.valid_up_to [`Condvar::new`]: https://doc.rust-lang.org/stable/std/sync/struct.Condvar.html#method.new [`Mutex::new`]: https://doc.rust-lang.org/stable/std/sync/struct.Mutex.html#method.new [`RwLock::new`]: https://doc.rust-lang.org/stable/std/sync/struct.RwLock.html#method.new

rust-highfive assigned Mark-Simulacrum Mar 15, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2022

SimonSapin mentioned this pull request Mar 15, 2022

Tracking issue for RFC 1861: Extern types #43467

Open

7 tasks

This comment has been minimized.

Sign in to view

SimonSapin force-pushed the null-thin3 branch from c0489e0 to de14731 Compare March 15, 2022 09:41

This comment has been minimized.

Sign in to view

SimonSapin force-pushed the null-thin3 branch 2 times, most recently from c0befc4 to ab13ccf Compare March 15, 2022 10:40

This comment has been minimized.

Sign in to view

SimonSapin force-pushed the null-thin3 branch from ab13ccf to f76539c Compare March 15, 2022 11:19

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 15, 2022

SimonSapin commented Mar 15, 2022

View reviewed changes

rust-highfive assigned yaahc and unassigned Mark-Simulacrum Mar 18, 2022

dtolnay added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 29, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Mar 29, 2022

SimonSapin force-pushed the null-thin3 branch 2 times, most recently from 39e4b28 to 173d872 Compare April 26, 2022 13:36

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels May 8, 2022

This comment has been minimized.

Sign in to view

SimonSapin force-pushed the null-thin3 branch from 3a56016 to 7ccc09b Compare May 13, 2022 16:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 24, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label May 25, 2022

bors merged commit 9fed130 into rust-lang:master May 25, 2022

rustbot added this to the 1.63.0 milestone May 25, 2022

apiraino removed the to-announce Announce this issue on triage meeting label May 27, 2022

RalfJung reviewed Jun 5, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend ptr::null and null_mut to all thin (including extern) types #94954

Extend ptr::null and null_mut to all thin (including extern) types #94954

SimonSapin commented Mar 15, 2022

rust-highfive commented Mar 15, 2022

This comment has been minimized.

This comment has been minimized.

SimonSapin commented Mar 15, 2022

This comment has been minimized.

SimonSapin Mar 15, 2022 •

edited

Loading

Ericson2314 Mar 15, 2022

clarfonthey Apr 23, 2022

SimonSapin Apr 23, 2022

Gankra Apr 23, 2022 •

edited

Loading

SimonSapin Apr 26, 2022

RalfJung Jun 5, 2022

RalfJung Jun 5, 2022

Mark-Simulacrum commented Mar 18, 2022

Gankra commented Mar 28, 2022

yaahc commented Mar 28, 2022

yaahc commented Mar 28, 2022

dtolnay commented Mar 29, 2022

rfcbot commented Mar 29, 2022 •

edited by Amanieu

Loading

This comment has been minimized.

SimonSapin commented May 13, 2022

rfcbot commented May 18, 2022

yaahc commented May 24, 2022

bors commented May 24, 2022

bors commented May 24, 2022

bors commented May 24, 2022

rust-log-analyzer commented May 24, 2022

lcnr commented May 25, 2022

bors commented May 25, 2022

bors commented May 25, 2022

rust-timer commented May 25, 2022

RalfJung Jun 5, 2022

Extend ptr::null and null_mut to all thin (including extern) types #94954

Extend ptr::null and null_mut to all thin (including extern) types #94954

Conversation

SimonSapin commented Mar 15, 2022

rust-highfive commented Mar 15, 2022

This comment has been minimized.

This comment has been minimized.

SimonSapin commented Mar 15, 2022

This comment has been minimized.

SimonSapin Mar 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gankra Apr 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mark-Simulacrum commented Mar 18, 2022

Gankra commented Mar 28, 2022

yaahc commented Mar 28, 2022

Footnotes

yaahc commented Mar 28, 2022

dtolnay commented Mar 29, 2022

rfcbot commented Mar 29, 2022 • edited by Amanieu Loading

This comment has been minimized.

SimonSapin commented May 13, 2022

rfcbot commented May 18, 2022

yaahc commented May 24, 2022

bors commented May 24, 2022

bors commented May 24, 2022

bors commented May 24, 2022

rust-log-analyzer commented May 24, 2022

lcnr commented May 25, 2022

bors commented May 25, 2022

bors commented May 25, 2022

rust-timer commented May 25, 2022

Footnotes

Choose a reason for hiding this comment

SimonSapin Mar 15, 2022 •

edited

Loading

Gankra Apr 23, 2022 •

edited

Loading

rfcbot commented Mar 29, 2022 •

edited by Amanieu

Loading