Make most std::ops traits const on numeric types #89876

AlexApps99 · 2021-10-14T08:41:30Z

This PR makes existing implementations of std::ops traits (Add, Sub, etc) impl const where possible.
This affects:

All numeric primitives (u*, i*, f*)
NonZero*
Wrapping

This is under the rustc_const_unstable feature const_ops.
I will write tests once I know what can and can't be kept for the final version of this PR.

Since this is my first PR to rustc (and hopefully one of many), please give me feedback on how to better handle the PR process wherever possible. Thanks

Zulip discussion

rust-highfive · 2021-10-14T08:41:33Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

bors · 2021-10-20T01:45:15Z

☔ The latest upstream changes (presumably #90067) made this pull request unmergeable. Please resolve the merge conflicts.

AlexApps99 · 2021-10-20T02:17:54Z

Looks like someone's PR beat me to it (#90009).
A bit disheartening, but only a small part of this PR.
Hopefully it can be reviewed soon.
In the mean time, I am writing a tracking issue.

oli-obk · 2021-10-20T19:21:20Z

r? @oli-obk

oli-obk · 2021-10-20T19:22:17Z

As discussed in the libs-api meeting today, @rust-lang/wg-const-eval may now approve unstably adding const to trait impls, including using ~const.

library/core/src/internal_macros.rs

oli-obk

The impl looks good! We can go ahead with all of these. Just needs those tests you talked about.

AlexApps99 · 2021-10-20T23:29:38Z

Starting tests now, are the files library/core/tests/{nonzero,num/{int_macros,ops,uint_macros,wrapping}}.rs good places to start?

fee1-dead · 2021-10-21T01:22:19Z

Starting tests now, are the files library/core/tests/{nonzero,num/{int_macros,ops,uint_macros,wrapping}}.rs good places to start?

Yes.

rust-lang/wg-const-eval may now approve unstably adding const to trait impls, including using ~const.

We should not approve ~const usages yet, since it kind of messes up the predicate evaluation cache. The ParamEnv fix should get landed first, and then we allow ~const.

oli-obk · 2021-10-21T07:23:25Z

Ah yea, that is next on my list anyway, might have a PR up today

bors · 2021-10-21T11:33:02Z

☔ The latest upstream changes (presumably #90119) made this pull request unmergeable. Please resolve the merge conflicts.

# Conflicts: # library/core/src/lib.rs

oli-obk · 2021-10-30T09:49:32Z

@bors r+ rollup

bors · 2021-10-30T09:49:34Z

📌 Commit 361c978 has been approved by oli-obk

AlexApps99 · 2021-10-30T09:51:30Z

I haven't completed the tests yet (mostly for a lack of time), are you sure it's OK to be merged without them?

Make most std::ops traits const on numeric types This PR makes existing implementations of `std::ops` traits (`Add`, `Sub`, etc) [`impl const`](rust-lang#67792) where possible. This affects: - All numeric primitives (`u*`, `i*`, `f*`) - `NonZero*` - `Wrapping` This is under the `rustc_const_unstable` feature `const_ops`. I will write tests once I know what can and can't be kept for the final version of this PR. Since this is my first PR to rustc (and hopefully one of many), please give me feedback on how to better handle the PR process wherever possible. Thanks [Zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Const.20std.3A.3Aops.20traits.20PR)

…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#89876 (Make most std::ops traits const on numeric types) - rust-lang#90371 (Fix incorrect doc link) - rust-lang#90374 (Unify titles in rustdoc book doc attributes chapter) - rust-lang#90377 (Make `core::slice::from_raw_parts[_mut]` const) - rust-lang#90395 (Restrict liveness of mutable borrow of inner infcx in ConstInferUnifier::consts) - rust-lang#90396 (Prevent type flags assertions being thrown in default_anon_const_substs if errors occurred) - rust-lang#90402 (Add a few query descriptions) - rust-lang#90412 (Remove unnecessary `macro_use`s in rustdoc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

RalfJung · 2021-11-03T14:55:37Z

I haven't completed the tests yet (mostly for a lack of time), are you sure it's OK to be merged without them?

Could you open an issue to track adding those tests, maybe leaving some notes for what kinds of tests you think would be good to have?

AlexApps99 · 2021-11-03T20:05:45Z

I'll put it on the tracking issue, I'm busy with exams right now but I should be able to set aside some time to implement the tests in a week or two.

ChaiTRex · 2022-07-24T15:54:48Z

This seems to add const to u8 >> i32, but not to &u8 >> i32, even though there's an implementation for both.

fee1-dead · 2022-07-24T17:00:23Z

This seems to add const to u8 >> i32, but not to &u8 >> i32, even though there's an implementation for both.

Does this work?

ChaiTRex · 2022-07-25T16:42:03Z

This seems to add const to u8 >> i32, but not to &u8 >> i32, even though there's an implementation for both.

Does this work?

Ahh, I see the problem. I was using #![feature(const_ops)] instead of #![feature(const_trait_impl)]. The latter works. Thanks.

rust-highfive assigned m-ou-se Oct 14, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2021

oli-obk added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Oct 14, 2021

AlexApps99 mentioned this pull request Oct 20, 2021

Tracking Issue for const_ops #90080

Closed

4 tasks

AlexApps99 force-pushed the const_ops branch from 3735575 to 90eb42d Compare October 20, 2021 02:38

AlexApps99 marked this pull request as ready for review October 20, 2021 02:40

oli-obk added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Oct 20, 2021

oli-obk mentioned this pull request Oct 20, 2021

Make From impls of NonZero integer const. #90077

Merged

oli-obk removed T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Oct 20, 2021

rust-highfive assigned oli-obk and unassigned m-ou-se Oct 20, 2021

oli-obk reviewed Oct 20, 2021

View reviewed changes

library/core/src/internal_macros.rs Show resolved Hide resolved

oli-obk requested changes Oct 20, 2021

View reviewed changes

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 21, 2021

AlexApps99 added 2 commits October 22, 2021 10:03

Added const versions of common numeric operations

23d033e

# Conflicts: # library/core/src/lib.rs

Added docs to internal_macro const

361c978

AlexApps99 force-pushed the const_ops branch from 3ae9b7b to 361c978 Compare October 21, 2021 21:07

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 30, 2021

matthiaskrgr mentioned this pull request Oct 30, 2021

Rollup of 10 pull requests #90415

Closed

matthiaskrgr mentioned this pull request Oct 30, 2021

Rollup of 8 pull requests #90416

Merged

bors merged commit 20bb932 into rust-lang:master Oct 30, 2021

rustbot added this to the 1.58.0 milestone Oct 30, 2021

camelid mentioned this pull request Nov 2, 2021

perf regression for doc generation from rollup 90416 #90512

Open

fee1-dead mentioned this pull request Mar 6, 2022

Add Result::{ok, err, and, or, unwrap_or} as const #92385

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make most std::ops traits const on numeric types #89876

Make most std::ops traits const on numeric types #89876

AlexApps99 commented Oct 14, 2021

rust-highfive commented Oct 14, 2021

bors commented Oct 20, 2021

AlexApps99 commented Oct 20, 2021

oli-obk commented Oct 20, 2021

oli-obk commented Oct 20, 2021

oli-obk left a comment

AlexApps99 commented Oct 20, 2021

fee1-dead commented Oct 21, 2021

oli-obk commented Oct 21, 2021

bors commented Oct 21, 2021

oli-obk commented Oct 30, 2021

bors commented Oct 30, 2021

AlexApps99 commented Oct 30, 2021

RalfJung commented Nov 3, 2021

AlexApps99 commented Nov 3, 2021

ChaiTRex commented Jul 24, 2022 •

edited

Loading

fee1-dead commented Jul 24, 2022

ChaiTRex commented Jul 25, 2022

Make most std::ops traits const on numeric types #89876

Make most std::ops traits const on numeric types #89876

Conversation

AlexApps99 commented Oct 14, 2021

rust-highfive commented Oct 14, 2021

bors commented Oct 20, 2021

AlexApps99 commented Oct 20, 2021

oli-obk commented Oct 20, 2021

oli-obk commented Oct 20, 2021

oli-obk left a comment

Choose a reason for hiding this comment

AlexApps99 commented Oct 20, 2021

fee1-dead commented Oct 21, 2021

oli-obk commented Oct 21, 2021

bors commented Oct 21, 2021

oli-obk commented Oct 30, 2021

bors commented Oct 30, 2021

AlexApps99 commented Oct 30, 2021

RalfJung commented Nov 3, 2021

AlexApps99 commented Nov 3, 2021

ChaiTRex commented Jul 24, 2022 • edited Loading

fee1-dead commented Jul 24, 2022

ChaiTRex commented Jul 25, 2022

ChaiTRex commented Jul 24, 2022 •

edited

Loading