Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bootstrap compiler to beta 1.53.0 #84985

Merged
merged 3 commits into from
May 25, 2021
Merged

Bump bootstrap compiler to beta 1.53.0 #84985

merged 3 commits into from
May 25, 2021

Conversation

pietroalbini
Copy link
Member

This PR bumps the bootstrap compiler to version 1.53.0 beta, as part of our usual release process (this was supposed to be Wednesday's step, but creating the beta release took longer than expected).

The PR also includes the "Bootstrap: skip rustdoc fingerprint for building docs" commit, see the reasoning on Zulip.

r? @Mark-Simulacrum

@rust-highfive
Copy link
Collaborator

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

Changes rustc_apfloat. rustc_apfloat is currently in limbo and you almost certainly don't want to change it (see #55993).

cc @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member

r=me modulo CI

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pietroalbini
Copy link
Member Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented May 6, 2021

📌 Commit fb16c5bd2666fb6e39c9e604197a199cbbc28442 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2021
@bors
Copy link
Contributor

bors commented May 7, 2021

☔ The latest upstream changes (presumably #85014) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 7, 2021
@pietroalbini
Copy link
Member Author

Rebased to fix the merge conflict.

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented May 7, 2021

📌 Commit ce768ae29f26687a575a976daf91160070950b2e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 8, 2021

⌛ Testing commit ce768ae29f26687a575a976daf91160070950b2e with merge 2e5f7f5f5084ecda6b78d0c280f0318d166bd5c7...

@bors
Copy link
Contributor

bors commented May 8, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 8, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pietroalbini
Copy link
Member Author

@bors r-

I'm a bit puzzled by this failure, #![feature(no_coverage)] is present in library/core/src/lib.rs...

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2021
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 10, 2021
@jyn514
Copy link
Member

jyn514 commented May 22, 2021

@pietroalbini #84871 may need to be backported

@Mark-Simulacrum
Copy link
Member

#85588 includes #84871 backport, will rebase this once that lands.

@bors
Copy link
Contributor

bors commented May 22, 2021

☔ The latest upstream changes (presumably #85078) made this pull request unmergeable. Please resolve the merge conflicts.

@12101111 12101111 mentioned this pull request May 23, 2021
Merged
@Mark-Simulacrum
Copy link
Member

Rebased along with a bump to the new beta (which included the relevant backport for the coverage attribute).

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented May 24, 2021

📌 Commit 9e22b84 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 24, 2021
@bors
Copy link
Contributor

bors commented May 25, 2021

⌛ Testing commit 9e22b84 with merge a7890c7...

@bors
Copy link
Contributor

bors commented May 25, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing a7890c7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 25, 2021
@bors bors merged commit a7890c7 into rust-lang:master May 25, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 25, 2021
This was referenced May 25, 2021
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
9 participants
@pietroalbini @rust-highfive @rust-log-analyzer @Mark-Simulacrum @bors @jyn514 @eddyb @rustbot @ehuss