Code

Rollup of 12 pull requests#79369

Code

Closed

Dylan-DPC-zz wants to merge 174 commits intorust-lang:masterrust-lang/rust:masterfrom Dylan-DPC-zz:rollup-nxubuxuDylan-DPC-zz/rust:rollup-nxubuxuCopy head branch name to clipboard

+4,265-2,064

Commits

Commits on Oct 4, 2020

• split interior_mutable_const tests and clean it

  Show description for be81608
  rail-rain

  committed
  be81608

• fix a FP in interior_mutable_const

  Show description for f58a169
  rail-rain

  committed
  f58a169

Commits on Oct 30, 2020

• Fix vec_box scope error

  Show description for 7c74d87
  camsteffen

  committed
  7c74d87

• Fix unnecessary_lazy_eval suggestion applicability

  Show description for c0d1002
  camsteffen

  committed
  c0d1002

Commits on Nov 2, 2020

• Fix incorrect suggestion for macro expansion in deref_addrof lint

  ThibsG

  committed
  158bf9a

• Give better suggestion by working on span on deref_addrof lint

  ThibsG

  committed
  343bdb3

• Fix incorrect suggestion when from expansion in try_err lint

  ThibsG

  committed
  ce98468

• Include bindings as machine applicable

  camsteffen

  committed
  a6611de

Commits on Nov 3, 2020

• rustc_ast: Do not panic by default when visiting macro calls

  petrochenkov

  committed
  89fa373

• rustc_ast: visit_mac -> visit_mac_call

  petrochenkov

  committed
  c2a769f

Commits on Nov 4, 2020

• Fix example for cargo common data

  Urcra

  committed
  a4acb31

• Readme improvements

  Show description for fd8dece
  camsteffen

  committed
  fd8dece

Commits on Nov 5, 2020

• Add string_from_utf8_as_bytes linter

  Show description for bc27d14
  patrickelectric

  committed
  bc27d14

• Skip rustfmt as it is wanted for this test

  ThibsG

  committed
  f83762b

• Merge commit 'b20d4c155d2fe3a8391f86dcf9a8c49e17188703' into clippyup

  flip1995

  committed
  3424419

• Fix incorrect suggestion for try_err lint when Err arg is itself a macro

  ThibsG

  committed
  83e75f9

• Fix await_holding_refcell_ref examples for clarify

  JohnTitor

  committed
  1e4ce0f

• Fix suggestion to add unneeded space in manual_async

  giraffate

  committed
  1624b00

Commits on Nov 6, 2020

• do not trigger map_clone in the case of &mut

  alex-700

  committed
  5f57608

• Refactor to make getting position just before RArrow a common function

  giraffate

  committed
  b7892c6

• Remove needless allow

  ThibsG

  committed
  8242b2f

• Auto merge of rust-lang#6294 - giraffate:fix_suggestion_to_add_space_in_manual_async, r=Manishearth

  Show description for 2ea08e1
  bors

  committed
  2ea08e1

• FROM_ITER_INSTEAD_OF_COLLECT: avoid unwrapping unconditionally

  Show description for 5253595
  matthiaskrgr

  committed
  5253595

Commits on Nov 7, 2020

• Auto merge of rust-lang#6272 - camsteffen:unnecesary-lazy-eval-type, r=llogiq

  Show description for 4bbef42
  bors

  committed
  4bbef42

• Auto merge of rust-lang#6110 - rail-rain:care_enums_non_copy_const, r=llogiq

  Show description for 694cec1
  bors

  committed
  694cec1

• Auto merge of rust-lang#6134 - patrickelectric:as_utf8, r=llogiq

  Show description for 92ba075
  bors

  committed
  92ba075

• Auto merge of rust-lang#6287 - camsteffen:readme, r=llogiq

  Show description for 4aca13f
  bors

  committed
  4aca13f

• Auto merge of rust-lang#6298 - JohnTitor:fix-example, r=llogiq

  Show description for 5effc99
  bors

  committed
  5effc99

• Auto merge of rust-lang#6304 - matthiaskrgr:crash_6302, r=llogiq

  Show description for c015622
  bors

  committed
  c015622

Commits on Nov 8, 2020

• Auto merge of rust-lang#6301 - alex-700:fix-map-clone, r=matthiaskrgr

  Show description for 96d5f45
  bors

  committed
  96d5f45

• Enable empty_loop lint for no_std crates

  Show description for c6a91df
  

  josephlr

  authored and

  flip1995

  committed
  c6a91df

• Update clippy_lints/src/loops.rs

  Show description for 3579b7d
  

  josephlr

  and

  flip1995

  committed
  3579b7d

• Update reference files

  flip1995

  committed
  00dee9d

• Auto merge of rust-lang#6205 - josephlr:empty-loop2, r=flip1995

  Show description for abfa331
  bors

  committed
  abfa331

• Add let_underscore_drop

  smoelius

  committed
  f1f780c

• Auto merge of rust-lang#6271 - camsteffen:vec-box-import, r=flip1995

  Show description for b1faa7f
  bors

  committed
  b1faa7f

• Update references

  smoelius

  committed
  9c6a0b9

• Auto merge of rust-lang#6293 - Urcra:lint-example-fix, r=flip1995

  Show description for 7079de9
  bors

  committed
  7079de9

• Force contributors/reviewers to set _some_ changelog entry

  flip1995

  committed
  7c612c1

• Auto merge of rust-lang#6288 - flip1995:changelog_internal, r=matthiaskrgr

  Show description for 040d0ca
  bors

  committed
  040d0ca

• Make KNOW_TYPES static

  camsteffen

  committed
  b099406

• Fix or_fun_call for index operator

  camsteffen

  committed
  9cab084

• Auto merge of rust-lang#6267 - camsteffen:or-fun-idx, r=flip1995

  Show description for 2067a01
  bors

  committed
  2067a01

• Update clippy_lints/src/let_underscore.rs

  Show description for aa6bf1f
  

  smoelius

  and

  flip1995

  authored
  aa6bf1f

• Update clippy_lints/src/let_underscore.rs

  Show description for 9751cba
  

  smoelius

  and

  flip1995

  authored
  9751cba

• Update clippy_lints/src/let_underscore.rs

  Show description for 8211b59
  

  smoelius

  and

  flip1995

  authored
  8211b59

• Update lints

  smoelius

  committed
  40d7af5

• Do not collect tokens for doc comments

  petrochenkov

  committed
  8845f10

• Update references

  smoelius

  committed
  06e81bb

Commits on Nov 9, 2020

• Auto merge of rust-lang#6278 - ThibsG:DerefAddrOf, r=llogiq

  Show description for d212c38
  bors

  committed
  d212c38

• Allow let_underscore_drop in filter_methods test

  smoelius

  committed
  4852cca

• Rollup merge of rust-lang#78710 - petrochenkov:macvisit, r=davidtwco

  Show description for 6294300
  Dylan-DPC

  authored
  6294300

• Auto merge of rust-lang#6305 - smoelius:master, r=flip1995

  Show description for dd826b4
  bors

  committed
  dd826b4

Commits on Nov 10, 2020

• Merge remote-tracking branch 'upstream/master' into rustup

  ebroto

  committed
  3ea6f77

• Run cargo dev fmt

  ebroto

  committed
  effcb52

• Auto merge of rust-lang#6319 - ebroto:rustup, r=ebroto

  Show description for 467bf95
  bors

  committed
  467bf95

• Auto merge of rust-lang#6303 - ThibsG:OptionOptionSerde, r=ebroto

  Show description for d0858d0
  bors

  committed
  d0858d0

Commits on Nov 11, 2020

• Fix map_clone with deref and clone

  camsteffen

  committed
  7690944

• Auto merge of rust-lang#6269 - camsteffen:map-clone-deref, r=ebroto

  Show description for c4fc076
  bors

  committed
  c4fc076

• Added a lint as suggested in 6010 which recommends using contains()

  Show description for a1cf2d3
  rsulli55

  committed
  a1cf2d3

• Moved the tests for lint search_is_some to new files

  Show description for 431fcbc
  rsulli55

  committed
  431fcbc

• Ran tests/ui/update-all-references.sh" and cargo dev fmt`

  rsulli55

  committed
  55dc822

• Remove to_string on msg

  Show description for e9612f3
  

  rsulli55

  and

  flip1995

  committed
  e9612f3

• Remove borrow

  Show description for fb74b48
  

  rsulli55

  and

  flip1995

  committed
  fb74b48

• Added period back to lint search_is_some and ran

  Show description for ee1b959
  rsulli55

  committed
  ee1b959

• Cleaned up message and suggestion for lint_search_is_some

  rsulli55

  committed
  fd30313

• Update clippy_lints/src/methods/mod.rs

  Show description for 56d252c
  

  rsulli55

  and

  flip1995

  committed
  56d252c

• Change variable named foo and rerun update-all-references

  rsulli55

  committed
  5c1c50e

• Fix typo in comment

  Show description for f92f8d0
  eltociear

  authored
  f92f8d0

• Implement destructuring assignment for structs and slices

  Show description for 5f310d9
  

  fanzier

  and

  varkor

  committed
  5f310d9

• Fix suggestion in manual_range_contains when using float

  giraffate

  committed
  5f64867

• Add Metadata in std::os::fortanix_sgx::io::FromRawFd

  mzohreva

  committed
  d569696

Commits on Nov 12, 2020

• Auto merge of rust-lang#78782 - petrochenkov:nodoctok, r=Aaron1011

  Show description for 92ece84
  bors

  committed
  92ece84

• Auto merge of rust-lang#6325 - flip1995:rustup, r=flip1995

  Show description for bd13a35
  bors

  committed
  bd13a35

• Add missing stability attribute

  mzohreva

  committed
  084b0da

• Rollup merge of rust-lang#78836 - fanzier:struct-and-slice-destructuring, r=petrochenkov

  Show description for 3a648ff
  m-ou-se

  authored
  3a648ff

Commits on Nov 13, 2020

• Fix dogfood test

  giraffate

  committed
  c6b74df

• Auto merge of rust-lang#6329 - giraffate:sync-from-rust, r=matthiaskrgr

  Show description for cf7b4b0
  bors

  committed
  cf7b4b0

• update clippy test ouput

  vn-ki

  committed
  7987f39

Commits on Nov 14, 2020

• Auto merge of rust-lang#6320 - giraffate:fix_suggestion_in_manual_range_contains_using_float, r=llogiq

  Show description for 408b615
  bors

  committed
  408b615

• Add underscore expressions for destructuring assignments

  Show description for 864e554
  

  fanzier

  and

  varkor

  committed
  864e554

• Auto merge of rust-lang#78809 - vn-ki:fix-issue-76064, r=oli-obk

  Show description for 0c7a48c
  bors

  committed
  0c7a48c

• Introduce TypeVisitor::BreakTy

  LeSeulArtichaut

  committed
  cbb6b1c

• Set the default BreakTy to !

  LeSeulArtichaut

  committed
  1b55cc7

Commits on Nov 15, 2020

• Rollup merge of rust-lang#79016 - fanzier:underscore-expressions, r=petrochenkov

  Show description for 27a1572
  jonas-schievink

  authored
  27a1572

• Auto merge of rust-lang#6334 - flip1995:rustup, r=flip1995

  Show description for db04641
  bors

  committed
  db04641

Commits on Nov 16, 2020

• Add rustfmt::skip as a work around

  Show description for 0e80341
  giraffate

  committed
  0e80341

• Auto merge of rust-lang#6336 - giraffate:sync-from-rust, r=flip1995

  Show description for df3bb58
  bors

  committed
  df3bb58

• Auto merge of rust-lang#6119 - rsulli55:find_is_some_on_strs, r=flip1995

  Show description for ad4f829
  bors

  committed
  ad4f829

• clippy: fold by value

  lcnr

  committed
  3567ea5

• Remove expect() calls to avoid ICEs in deref_addrof lint

  ThibsG

  committed
  5b8f2b6

Commits on Nov 17, 2020

• Auto merge of rust-lang#78779 - LeSeulArtichaut:ty-visitor-return, r=oli-obk

  Show description for a467c51
  bors

  committed
  a467c51

• Add new lint to detect unnecessarily wrapped value

  hkmatsumoto

  committed
  a7ac441

• Add suggestion on type signatures

  hkmatsumoto

  committed
  750c118

• Fix lint example

  hkmatsumoto

  committed
  0335b8d

• Add test cases

  hkmatsumoto

  committed
  0e9d227

• Refactor code according to reivews

  hkmatsumoto

  committed
  ebdd4e2

• Optout rustfix test

  hkmatsumoto

  committed
  6a62390

• Fix typo

  Show description for 3ed8902
  

  hkmatsumoto

  and

  flip1995

  committed
  3ed8902

• Call diag.multipart_suggestion instead

  hkmatsumoto

  committed
  c775856

• Run rustfmt

  hkmatsumoto

  committed
  a433d46

• Split lint suggestion into two

  hkmatsumoto

  committed
  cdb72df

• Add test case

  hkmatsumoto

  committed
  6b55f3f

• Move find_all_ret_expressions into utils

  hkmatsumoto

  committed
  df0d565

• Update clippy_lints/src/unnecessary_wrap.rs

  Show description for eec7f5c
  

  hkmatsumoto

  and

  flip1995

  committed
  eec7f5c

• Improve lint message

  hkmatsumoto

  committed
  1bdac87

• Run cargo dev fmt

  hkmatsumoto

  committed
  8392bc7

• Make lint skip closures

  hkmatsumoto

  committed
  2f85aa7

• Add support for methods

  hkmatsumoto

  committed
  12474c6

• Make lint skip macros

  hkmatsumoto

  committed
  c5447eb

• Skip function with no exprs contained

  hkmatsumoto

  committed
  c7692cf

• Allow this lint on lint tests

  hkmatsumoto

  committed
  30632fb

• Downgrade applicability to MaybeIncorrect

  hkmatsumoto

  committed
  e998d61

• Remove wildcard use

  hkmatsumoto

  committed
  9d96311

• Skip functions in PartialOrd

  hkmatsumoto

  committed
  532d205

• Fix clippy error

  hkmatsumoto

  committed
  bf46f78

• Update stderr files

  hkmatsumoto

  committed
  86331a4

• Update stderr files

  hkmatsumoto

  committed
  4c8d248

• Ignore trait implementations

  hkmatsumoto

  committed
  4e5c02e

• Fix embarrassing grammatical error

  hkmatsumoto

  committed
  1f577c0

• Pluralize lint name

  hkmatsumoto

  committed
  c7445d7

• Run cargo dev fmt

  flip1995

  committed
  bf2d31d

• Auto merge of rust-lang#6338 - flip1995:rustup, r=flip1995

  Show description for a8cafc6
  bors

  committed
  a8cafc6

• Auto merge of rust-lang#6337 - ThibsG:FixIce6332, r=Manishearth

  Show description for 5464cbe
  bors

  committed
  5464cbe

• Fix handling of panic calls

  Show description for 4e4c4fb
  camelid

  committed
  4e4c4fb

• Auto merge of rust-lang#6070 - matsujika:unnecessary_wrap, r=flip1995

  Show description for 44d9445
  bors

  committed
  44d9445

• Improve doc about map_clone

  giraffate

  committed
  0502ac2

Commits on Nov 18, 2020

• Auto merge of rust-lang#6340 - giraffate:improve_doc_for_map_clone, r=Manishearth

  Show description for 8c2e2fd
  bors

  committed
  8c2e2fd

• Revert "Add rustfmt::skip as a work around"

  Show description for 6494bd0
  giraffate

  committed
  6494bd0

• Rollup merge of rust-lang#79145 - camelid:clippy-fix-panics, r=flip1995

  Show description for 577ebc8
  m-ou-se

  authored
  577ebc8

Commits on Nov 19, 2020

• Auto merge of rust-lang#6345 - giraffate:follow_up_of_rustup, r=flip1995

  Show description for b2aefb8
  bors

  committed
  b2aefb8

• Add CHANGELOG for 1.48

  flip1995

  committed
  4bf58bd

• Fix trailing whitespaces in CHANGELOG file

  flip1995

  committed
  a98acdb

• Improve changlog update documentation

  flip1995

  committed
  e9afdf0

• Remove the clippy::panic-params lint.

  Show description for 78faaef
  m-ou-se

  committed
  78faaef

• Clippy: Match on assert!() expansions without an inner block.

  m-ou-se

  committed
  113c147

Commits on Nov 20, 2020

• Properly deprecate panic_params lint

  flip1995

  committed
  dd4e471

• Fix dogfood errors

  flip1995

  committed
  5ee0a40

• Auto merge of rust-lang#6351 - flip1995:rustup, r=flip1995

  Show description for 8325d48
  bors

  committed
  8325d48

• Auto merge of rust-lang#6347 - flip1995:changelog, r=Manishearth

  Show description for 70ffebf
  bors

  committed
  70ffebf

• Revert "Convert the await holding lints to correctness"

  Show description for 8b21241
  

  Daniel Smith

  committed
  8b21241

• Auto merge of rust-lang#6354 - Daniel-B-Smith:refcell_ref_await, r=flip1995

  Show description for 0402c6a
  bors

  committed
  0402c6a

Commits on Nov 22, 2020

• a typo

  Show description for 9b910e1
  

  oliver

  authored
  9b910e1

• update

  

  oliver

  committed
  e30bb76

• Add test for an unmotivated "cannot determine resolution" error

  petrochenkov

  committed
  6667c66

• resolve: Do not put macros into module.unexpanded_invocations unless necessary

  petrochenkov

  committed
  27af650

• Auto merge of rust-lang#6364 - o752d:master, r=flip1995

  Show description for 4284ec3
  bors

  committed
  4284ec3

• Auto merge of rust-lang#6363 - o752d:patch-2, r=flip1995

  Show description for 831aa96
  bors

  committed
  831aa96

• Small grammar, punctuation, and code style improvements to docs

  carols10cents

  committed
  034244f

• Apply suggestions from code review to change "that" to "which"

  Show description for 445466e
  

  carols10cents

  and

  oliver

  committed
  445466e

• Auto merge of rust-lang#6361 - integer32llc:doc-style, r=carols10cents

  Show description for 3e7c6de
  bors

  committed
  3e7c6de

• Make fold_item_recur non-nullable

  Show description for ab1e634
  jyn514

  committed
  ab1e634

• Get rid of doctree::Impl

  jyn514

  committed
  0043fc9

• Accept '!' in intra-doc links

  Show description for 0b6537a
  camelid

  committed
  0b6537a

Commits on Nov 23, 2020

• Allow using -Z fewer-names=no to retain value names

  Show description for fafe3cd
  tmiasko

  committed
  fafe3cd

• Merge commit '3e7c6dec244539970b593824334876f8b6ed0b18' into clippyup

  flip1995

  committed
  dfac9be

• Fix ICE in utils::implements_trait

  Show description for 99b9459
  flip1995

  committed
  99b9459

• Fix typo in keyword docs for traits

  Takashiidobe

  committed
  c5c3d7b

• BTreeMap: cut out the ceremony around BoxedNode

  ssomers

  committed
  8526c31

• BTreeMap/BTreeSet: make public doc more consistent

  ssomers

  committed
  9c8db45

• Make ui test that are run-pass and do not test the compiler itself library tests

  CDirkx

  committed
  fcbe638

Commits on Nov 24, 2020

• Allow disabling TrapUnreachable via -Ztrap-unreachable=no

  Show description for 7b62e09
  Dirbaio

  committed
  7b62e09

• Rollup merge of rust-lang#78953 - mzohreva:mz/from_raw_fd, r=Mark-Simulacrum

  Show description for 04db18d
  Dylan-DPC

  authored
  04db18d

• Rollup merge of rust-lang#79038 - CDirkx:move-ui-tests, r=dtolnay

  Show description for 21b3fc0
  Dylan-DPC

  authored
  21b3fc0

• Rollup merge of rust-lang#79228 - flip1995:clippyup, r=oli-obk

  Show description for f7875d3
  Dylan-DPC

  authored
  f7875d3

• Rollup merge of rust-lang#79294 - petrochenkov:determ, r=varkor

  Show description for 8c315c6
  Dylan-DPC

  authored
  8c315c6

• Rollup merge of rust-lang#79310 - jyn514:fold-item-cleanup, r=GuillaumeGomez

  Show description for e6349ac
  Dylan-DPC

  authored
  e6349ac

• Rollup merge of rust-lang#79312 - jyn514:doctree-impl, r=GuillaumeGomez

  Show description for 5b492c9
  Dylan-DPC

  authored
  5b492c9

• Rollup merge of rust-lang#79321 - camelid:intra-doc-bang, r=Manishearth

  Show description for 9a05fd6
  Dylan-DPC

  authored
  9a05fd6

• Rollup merge of rust-lang#79346 - tmiasko:more-names, r=jonas-schievink

  Show description for f013b4d
  Dylan-DPC

  authored
  f013b4d

• Rollup merge of rust-lang#79351 - Takashiidobe:keyword-docs-typo, r=m-ou-se

  Show description for 1361d74
  Dylan-DPC

  authored
  1361d74

• Rollup merge of rust-lang#79354 - ssomers:btree_bereave_BoxedNode, r=Mark-Simulacrum

  Show description for a8c1597
  Dylan-DPC

  authored
  a8c1597

• Rollup merge of rust-lang#79358 - ssomers:btree_public_comments, r=Mark-Simulacrum

  Show description for 0e7ce1e
  Dylan-DPC

  authored
  0e7ce1e

• Rollup merge of rust-lang#79367 - Dirbaio:trap-unreachable, r=jonas-schievink

  Show description for e5a4e14
  Dylan-DPC

  authored
  e5a4e14