Code

Add lint for panic!("{}")#78088

Code

Merged

bors merged 28 commits intorust-lang:masterrust-lang/rust:masterfrom fusion-engineering-forks:panic-fmt-lintfusion-engineering-forks/rust:panic-fmt-lintCopy head branch name to clipboardNov 20, 2020

+362-165

Commits

Commits on Oct 18, 2020

• Mark the panic macros as diagnostic items.

  m-ou-se

  committed
  462ee9c

  Copy full SHA for 462ee9c

• Add lint to warn about braces in a panic message.

  m-ou-se

  committed
  a466790

  Copy full SHA for a466790

• Allow #[rustc_diagnostic_item] on macros.

  m-ou-se

  committed
  5b3b80a

  Copy full SHA for 5b3b80a

• Specialize panic_fmt lint for the {core,std}::panic!() macros.

  Show description for da66a50
  m-ou-se

  committed
  da66a50

  Copy full SHA for da66a50

• Make panic_fmt lint work properly for assert!(expr, msg) too.

  m-ou-se

  committed
  f228efc

  Copy full SHA for f228efc

• Expand assert!(expr) to panic() function instead of panic!() macro.

  Show description for 3beb2e9
  m-ou-se

  committed
  3beb2e9

  Copy full SHA for 3beb2e9

• Add test for the panic_fmt lint.

  m-ou-se

  committed
  451c986

  Copy full SHA for 451c986

• Improve panic_fmt message for panic!("{}") with a fmt placeholder.

  m-ou-se

  committed
  ded269f

  Copy full SHA for ded269f

• Formatting.

  m-ou-se

  committed
  b8a8b68

  Copy full SHA for b8a8b68

• Test for formating placeholders in panic_fmt lint test.

  m-ou-se

  committed
  14dcf0a

  Copy full SHA for 14dcf0a

• Add cfg(not(bootstrap)) on the new rustc_diagnostic_item attributes.

  Show description for dd262e3
  m-ou-se

  committed
  dd262e3

  Copy full SHA for dd262e3

• Don't see {{}} as placeholder in panic_fmt lint.

  m-ou-se

  committed
  9615d27

  Copy full SHA for 9615d27

• Fix brace problem in panic message in rustc_expand.

  m-ou-se

  committed
  9a840a3

  Copy full SHA for 9a840a3

• Ignore panic_fmt lint in macro-comma-behavior-rpass ui test.

  m-ou-se

  committed
  0a9330c

  Copy full SHA for 0a9330c

• Also apply panic_fmt lint suggestions to debug_assert!().

  m-ou-se

  committed
  d3b4149

  Copy full SHA for d3b4149

• Ignore panic_fmt lint in format-args-capture ui test.

  m-ou-se

  committed
  f1fcc4d

  Copy full SHA for f1fcc4d

Commits on Oct 19, 2020

• Update mir-opt test output for new assert macro implementation.

  m-ou-se

  committed
  dd81c91

  Copy full SHA for dd81c91

• Fix braces in panic message in test.

  m-ou-se

  committed
  9e3b949

  Copy full SHA for 9e3b949

• Add cfg(not(test)) to std_panic_macro rustc_diagnostic_item.

  m-ou-se

  committed
  ff8df0b

  Copy full SHA for ff8df0b

• Small cleanups in assert!() and panic_fmt lint.

  Show description for 0f193d1
  

  m-ou-se

  and

  estebank

  committed
  0f193d1

  Copy full SHA for 0f193d1

Commits on Oct 20, 2020

• Parse the format string for the panic_fmt lint for better warnings.

  m-ou-se

  committed
  6b44662

  Copy full SHA for 6b44662

• Improve panic_fmt error messages for invalid format strings too.

  m-ou-se

  committed
  190c3ad

  Copy full SHA for 190c3ad

Commits on Oct 24, 2020

• Test that panic_fmt lint doesn't trigger for custom panic macro.

  m-ou-se

  committed
  1993f1e

  Copy full SHA for 1993f1e

Commits on Oct 28, 2020

• Mark panic_fmt suggestion as machine applicable.

  Show description for 5cefc3c
  

  m-ou-se

  and

  bjorn3

  committed
  5cefc3c

  Copy full SHA for 5cefc3c

Commits on Oct 29, 2020

• Improve panic_fmt lint messages.

  Show description for 9743f67
  

  m-ou-se

  and

  estebank

  committed
  9743f67

  Copy full SHA for 9743f67

• Add test for panic_fmt lint with external panic!()-calling macro.

  m-ou-se

  committed
  a922c6b

  Copy full SHA for a922c6b

Commits on Nov 19, 2020

• Remove the clippy::panic-params lint.

  Show description for 454eaec
  m-ou-se

  committed
  454eaec

  Copy full SHA for 454eaec

• Clippy: Match on assert!() expansions without an inner block.

  m-ou-se

  committed
  a125ef2

  Copy full SHA for a125ef2