Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in conventions.md #136323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a typo in conventions.md #136323

wants to merge 1 commit into from
+1 −1

Conversation

etaoins
Copy link
Contributor

@etaoins etaoins commented Jan 30, 2025

Introduced in #135950

@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

@tgross35
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 30, 2025

📌 Commit ba5386a has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2025
@tgross35 tgross35 assigned tgross35 and unassigned Noratrieb Jan 30, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 31, 2025
@jhpratt
Rollup merge of rust-lang#136323 - etaoins:fix-typo-in-conventions-md…
e429ada 
…, r=tgross35

Fix a typo in conventions.md

Introduced in rust-lang#135950
@jhpratt jhpratt mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@etaoins @rustbot @tgross35 @bors @Noratrieb