Delete Rvalue::Len 🎉
#134330
Draft
Delete Rvalue::Len 🎉
#134330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
scottmcm
commented
Dec 15, 2024
| // actual = len(place) | ||
| self.cfg.push_assign(block, source_info, actual, Rvalue::Len(place)); | ||
| let actual = self.len_of_slice_or_array(block, place, test.span, source_info); |
There was a problem hiding this comment.
One functional change here, reusing this helper from #133734
scottmcm
commented
Dec 15, 2024
| mir! { | ||
| { | ||
| let x = [5_i32; C]; | ||
| let c = Len(x); |
There was a problem hiding this comment.
This was here testing the custom-mir Len, which is removed here, so I deleted the test.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Everything's moved to `PtrMetadata` instead.
scottmcm
force-pushed
the
no-more-rvalue-len
branch
from
761e299 to
db4e734
Compare
|
☔ The latest upstream changes (presumably #134332) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything's moved to
PtrMetadata, so we can get rid of theLenvariant now.Depends on #134326, so draft until that lands
r? mir