Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove long-deprecated no-op attributes no_start and crate_id #134300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove long-deprecated no-op attributes no_start and crate_id #134300

wants to merge 1 commit into from
+163 −215

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 14, 2024 •
edited
Loading

These have emitted a deprecation warning since forever (#64471) and they already don't do anything. In fact they apparently have done nothing since pre-1.0, so... do we even need a crater run? Doesn't seem worth it.

@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2024

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 14, 2024
@RalfJung RalfJung added I-lang-nominated Nominated for discussion during a lang team meeting. S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed I-lang-nominated Nominated for discussion during a lang team meeting. labels Dec 14, 2024
@RalfJung
Copy link
Member Author

@bors try

@RalfJung RalfJung added I-lang-nominated Nominated for discussion during a lang team meeting. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 14, 2024
@bors
Copy link
Contributor

bors commented Dec 14, 2024

⌛ Trying commit f9444bb with merge be699666730c5a1745838222e98e2d85019affdc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 14, 2024
@bors
Auto merge of rust-lang#134300 - RalfJung:remove-dead-attrs, r=<try>
be69966 
remove long-deprecated no-op attributes no_start and crate_id

These have emitted a deprecation warning since forever (rust-lang#64471) and they already don't do anything.
@RalfJung RalfJung added the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label Dec 14, 2024
@bors
Copy link
Contributor

bors commented Dec 14, 2024

☀️ Try build successful - checks-actions
Build commit: be69966 (be699666730c5a1745838222e98e2d85019affdc)

@Urgau
Copy link
Member

Urgau commented Dec 14, 2024

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-134300 created and queued.
🤖 Automatically detected try build be69966
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Dec 14, 2024
@Urgau
Copy link
Member

Urgau commented Dec 14, 2024

(started an crater run because these attributes are stable, so they may be referenced even if they do nothing, seems safer to me)

@RalfJung RalfJung added the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chenyukang chenyukang

Labels
I-lang-nominated Nominated for discussion during a lang team meeting. S-waiting-on-crater Status: Waiting on a crater run to be completed. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @bors @Urgau @craterbot @chenyukang