disallow repr() on invalid items
#133925
Open
disallow repr() on invalid items
#133925
+107
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also this generates an error when `repr` is used on a trait method and the `fn_align` feature is not enabled. Looks like that was missed here: https://github.com/rust-lang/rust/pull/110313/files Which first enables the align attribute on trait methods.
rustbot
added
S-waiting-on-review
|
@bors try |
|
Nominating as a courtesy for T-lang, should be a trivial decision since this was likely never intended |
compiler-errors
added
the
I-lang-easy-decision
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2024
…<try> disallow `repr()` on invalid items fixes rust-lang#129606 Disallows `repr()` (so a repr with no arguments) on items where that won't ever make sense. Also this generates an error when `repr` is used on a trait method and the `fn_align` feature is not enabled. Looks like that was missed here: https://github.com/rust-lang/rust/pull/110313/files Which first accepts the align attribute on trait methods. r? `@compiler-errors`
This comment has been minimized.
This comment has been minimized.
|
Oh nice! If this fixes an issue you have right now, great! Especially the tests are nice so I can't mess it up again, but the code in |
|
well this change unintentionally turns out to fix that ICE. And yeah the test coverage is the most important part, I'm not at all attached to this code. Good luck with your rebase! |
|
lol thanks, can't be much worse than the current one (I'm 4 days in) |
|
r=me when T-lang comes back w/ a decision @rustbot team |
compiler-errors
added
S-waiting-on-team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #129606
fixes #132391
Disallows
repr()(so a repr with no arguments) on items where that won't ever make sense.Also this generates an error when
repris used on a trait method and thefn_alignfeature is not enabled. Looks like that was missed here:https://github.com/rust-lang/rust/pull/110313/files
Which first accepts the align attribute on trait methods.
r? @compiler-errors
cc @jdonszelmann who claimed #132391 and generally has been working on attributes