Rollup of 8 pull requests #133219
Merged
Rollup of 8 pull requests #133219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following methods, that work similarly to VecDeque::as_slices: - alloc::collections::vec_deque::Iter::as_slices - alloc::collections::vec_deque::IterMut::into_slices - alloc::collections::vec_deque::IterMut::as_slices - alloc::collections::vec_deque::IterMut::as_mut_slices Obtaining slices from a VecDeque iterator was not previously possible.
- Rename it as `invalid_ident_or_prefix`, which matches the possible
outputs (`InvalidIdent` or `InvalidPrefix`).
- Use the local wrapper for `is_xid_continue`, for consistency.
- Make it clear what `\u{200d}` means.
- Improve wording. - Use backticks consistently for examples.
It was added in rust-lang#123752 to handle some cases involving emoji, but it isn't necessary because it's always treated the same as `TokenKind::InvalidIdent`. This commit removes it, which makes things a little simpler.
This target is tier 2, not tier 3, and I forgot to update this. Closes rust-lang#133206
1. Make the effect thread local. 2. Don't return a io::Result from hooks.
Co-authored-by: waffle <[email protected]>
… r=Amanieu Add vec_deque::Iter::as_slices and friends Add the following methods, that work similarly to VecDeque::as_slices: - alloc::collections::vec_deque::Iter::as_slices - alloc::collections::vec_deque::IterMut::into_slices - alloc::collections::vec_deque::IterMut::as_slices - alloc::collections::vec_deque::IterMut::as_mut_slices Obtaining slices from a VecDeque iterator was not previously possible.
…affleLapkin Add std::thread::add_spawn_hook. Implementation of rust-lang/rfcs#3642
…obzol ci: use free runner in dist-i686-msvc try-job: dist-i686-msvc
…=joboet Mention std::fs::remove_dir_all in std::fs::remove_dir
…chenkov Add `visit` methods to ast nodes that already have `walk`s on ast visitors Some `walk` functions are called directly, because there were no correspondent visit functions. related to rust-lang#128974 & rust-lang#127615 r? `@petrochenkov`
…efix, r=compiler-errors Remove `TokenKind::InvalidPrefix` It's not needed. Best reviewed one commit at a time. r? `@estebank`
…jorn3 Default-enable `llvm_tools_enabled` when no `config.toml` is present Fixes rust-lang#133195. cc `@wesleywiser` could you double check if with this patch and no `config.toml` that you can run `./x test tests/ui --stage 1`? `llvm-objcopy` is usually required by cg_ssa on macOS to workaround bad `strip`s. cc `@bjorn3` I hope this doesn't break cg_clif... r? bootstrap
…ieyouxu Correct the tier listing of `wasm32-wasip2` This target is tier 2, not tier 3, and I forgot to update this. Closes rust-lang#133206
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: ee612c45f0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (875df37): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 2.5%, secondary -2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 0.3%, secondary 0.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 795.801s -> 793.735s (-0.26%) |
|
There's not much in this PR... This feels like noise, but we'll see on the next merge. |
|
Given that the regressions were only in helloworld and other similar tiny crates, and it seems like they were reverted: I'm marking this as triaged. @rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
visitmethods to ast nodes that already havewalks on ast visitors #133188 (Addvisitmethods to ast nodes that already havewalks on ast visitors)TokenKind::InvalidPrefix#133201 (RemoveTokenKind::InvalidPrefix)llvm_tools_enabledwhen noconfig.tomlis present #133207 (Default-enablellvm_tools_enabledwhen noconfig.tomlis present)wasm32-wasip2#133213 (Correct the tier listing ofwasm32-wasip2)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup