stabilize const_pin_2 #133127
Closed
stabilize const_pin_2 #133127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
tgross35
reviewed
Nov 17, 2024
| @@ -1214,7 +1214,7 @@ impl<Ptr: Deref<Target: Unpin>> Pin<Ptr> { | |||
| /// assert_eq!(*r, 5); | |||
| /// ``` | |||
| #[inline(always)] | |||
| #[rustc_const_unstable(feature = "const_pin_2", issue = "76654")] | |||
| #[rustc_const_stable(feature = "const_pin", since = "CURRENT_RUSTC_VERSION")] | |||
| #[stable(feature = "pin_into_inner", since = "1.39.0")] | |||
There was a problem hiding this comment.
These need const_precise_live_drops
|
There is a stabilization PR up at #131904, you could probably just cherry pick that commit and rebase if you want. |
RalfJung
force-pushed
the
const_pin_2
branch
from
76b371d to
2c51b8b
Compare
|
Oh, sorry, I didn't realize there's already a PR. |
|
We can use this one if the author doesn't get back before the 21st :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got split out from const_pin in #130136; we can merge them back together since it's still the same release cycle (assuming this lands fast enough).
r? @tgross35
Fixes #76654