Report the `unexpected_cfgs` lint in external macros #132577

Urgau · 2024-11-03T21:14:27Z

This PR marks the unexpected_cfgs lint as being reportable in external macros, as it's probably not the intention of the macro author to leave ineffective cfgs in the users code.

Fixes #132572

try-job: aarch64-gnu-debug

rustbot · 2024-11-03T21:14:35Z

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-11-04T18:17:50Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Urgau · 2024-11-04T18:17:56Z

The job x86_64-gnu-tools failed!

Fixed in rust-cli/anstyle#229 (thks to @epage)

Let's try again!

jieyouxu · 2024-11-05T15:24:00Z

Would this need a crater run?

Urgau · 2024-11-05T20:12:09Z

Would this need a crater run?

Evaluating the new unexpected_cfgs warnings coming from external macros on a crater run is doable (although not easy), but I'm not sure what it will give us, a part (obviously) from the number of impacted crates, which I'm not sure how to interpret. A big (or even small) number of warnings would IMO only reinforce the usefulness of enabling the reporting in external macros (not that it needs it to be clear).

Is there something particular you are looking for?

jieyouxu · 2024-11-06T01:58:30Z

No I'm more just curious, because maybe a few crates are affected.

Urgau · 2024-11-08T06:46:36Z

r? @petrochenkov

petrochenkov · 2024-11-09T20:06:04Z

@bors r+

bors · 2024-11-09T20:06:07Z

📌 Commit 37e67ac has been approved by petrochenkov

It is now in the queue for this repository.

…o, r=petrochenkov Report the `unexpected_cfgs` lint in external macros This PR marks the `unexpected_cfgs` lint as being reportable in external macros, as it's probably not the intention of the macro author to leave ineffective cfgs in the users code. Fixes rust-lang#132572

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132577 (Report the `unexpected_cfgs` lint in external macros) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2024-11-10T03:11:49Z

@bors r-
Seems to have failed in #132827 (comment)

workingjubilee · 2024-11-10T03:12:13Z

@bors try

… r=<try> Report the `unexpected_cfgs` lint in external macros This PR marks the `unexpected_cfgs` lint as being reportable in external macros, as it's probably not the intention of the macro author to leave ineffective cfgs in the users code. Fixes rust-lang#132572 try-job: aarch64-gnu-debug

bors · 2024-11-10T03:13:23Z

⌛ Trying commit 37e67ac with merge 6606d0e...

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#131081 (Use `ConstArgKind::Path` for all single-segment paths, not just params under `min_generic_const_args`) - rust-lang#132577 (Report the `unexpected_cfgs` lint in external macros) - rust-lang#133023 (Merge `-Zhir-stats` into `-Zinput-stats`) - rust-lang#133200 (ignore an occasionally-failing test in Miri) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132577 - Urgau:check-cfg-report-extern-macro, r=petrochenkov Report the `unexpected_cfgs` lint in external macros This PR marks the `unexpected_cfgs` lint as being reportable in external macros, as it's probably not the intention of the macro author to leave ineffective cfgs in the users code. Fixes rust-lang#132572 try-job: aarch64-gnu-debug

This recent change is causing CI to fail: rust-lang/rust#132577 The failure is caused by the `used_linker` feature in code produced by the `ctor::ctor` attribute macro.

Rustc 1.84 (nightly) introduced that the `unexpected_cfg`s lint will now be reported for external macros (see rust-lang/rust#132577), leading to some of our builds failing due to our `level = "forbid"` config of unexpected cfg flags. Here, we add the logging features to the expected features of the workspace to mitigiate this issue and fix builds.

As of nightly-2024-11-20 - specifically [1] - this triggers an `unexpected_cfgs` lint even when emitted in derive-generated code. [1] rust-lang/rust#132577 Fixes #2117 gherrit-pr-id: I9d536f0ea08475afe0b65411b225aa55f4db449a

Since rust-lang/rust#132577 (currently in rust nightly), we get hundreds of lint warnings: ``` warning: unexpected `cfg` condition name: `wasm_bindgen_unstable_test_coverage` --> src/rust/lib.rs:83:1 | 83 | #[wasm_bindgen(start)] ``` The correct solution is to upgrade wasm-bindgen, but legend has it that is difficult. For now, let's silence the lint.

…ouxu Add external macros specific diagnostics for check-cfg This PR adds specific check-cfg diagnostics for unexpected cfg in external macros. As well as hiding the some of the Cargo specific help/suggestions as they distraction for external macros and are generally not the right solution. Follow-up to rust-lang#132577 `@rustbot` label +L-unexpected_cfgs r? compiler

Rollup merge of rust-lang#133221 - Urgau:check-cfg-macro-diag, r=jieyouxu Add external macros specific diagnostics for check-cfg This PR adds specific check-cfg diagnostics for unexpected cfg in external macros. As well as hiding the some of the Cargo specific help/suggestions as they distraction for external macros and are generally not the right solution. Follow-up to rust-lang#132577 `@rustbot` label +L-unexpected_cfgs r? compiler

rustbot assigned wesleywiser Nov 3, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2024

This comment has been minimized.

Sign in to view

jieyouxu added the L-unexpected_cfgs Lint: unexpected_cfgs label Nov 4, 2024

This comment has been minimized.

Sign in to view

Urgau mentioned this pull request Nov 5, 2024

Avoid using unexpected cfgs in user code rust-lang/stdarch#1667

Merged

rustbot assigned petrochenkov and unassigned wesleywiser Nov 8, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2024

matthiaskrgr mentioned this pull request Nov 9, 2024

Rollup of 4 pull requests #132827

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2024

This comment has been minimized.

Sign in to view

bors merged commit 4720054 into rust-lang:master Nov 19, 2024
6 checks passed

rustbot added this to the 1.84.0 milestone Nov 19, 2024

Urgau mentioned this pull request Nov 19, 2024

Add external macros specific diagnostics for check-cfg #133221

Merged

This was referenced Nov 20, 2024

Allowing the unexpected_cfgs lint rust-fuzz/afl.rs#556

Merged

Unexpected cfgs beginning with nightly-2024-11-20 mmastrac/rust-ctor#309

Closed

daxpedda mentioned this pull request Nov 20, 2024

Don't emit unexpected cfgs in proc-macros rustwasm/wasm-bindgen#4284

Merged

calebzulawski mentioned this pull request Nov 22, 2024

Retpoline-related cfgs seems to be gone on nightly calebzulawski/multiversion#46

Closed

tnull mentioned this pull request Nov 26, 2024

Fix expected-cfg-checks for logging features lightningdevkit/rust-lightning#3425

Closed

zecakeh mentioned this pull request Nov 29, 2024

Some macros leak the unstable-exhaustive-types cargo feature ruma/ruma#1956

Closed

This was referenced Nov 29, 2024

create_exception macro triggers unexpected_cfgs lint in nightly build PyO3/pyo3#4743

Closed

build: Bump Rust toolchain to nightly-2024-11-28 pola-rs/polars#20064

Merged

apoelstra mentioned this pull request Nov 29, 2024

Release tracking PR: bitcoin 0.32.5 rust-bitcoin/rust-bitcoin#3664

Merged

sirno mentioned this pull request Dec 2, 2024

Current nightly versions trigger unexpected_cfgs warning. ExpHP/npyz#72

Open

jswrenn mentioned this pull request Dec 2, 2024

Regression: "unexpected cfg condition name: coverage_nightly" #133775

Closed

joshlf mentioned this pull request Dec 3, 2024

[derive] Don't emit #[cfg(coverage_nightly)] google/zerocopy#2123

Merged

joshlf mentioned this pull request Dec 3, 2024

[derive] Don't emit #[cfg(coverage_nightly)] (#2123) google/zerocopy#2126

Merged

richvdh mentioned this pull request Dec 10, 2024

Silence annoying lint warning matrix-org/matrix-rust-sdk-crypto-wasm#177

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report the `unexpected_cfgs` lint in external macros #132577

Report the `unexpected_cfgs` lint in external macros #132577

Urgau commented Nov 3, 2024 •

edited by workingjubilee

Loading

rustbot commented Nov 3, 2024

This comment has been minimized.

rustbot commented Nov 4, 2024

Urgau commented Nov 4, 2024

This comment has been minimized.

jieyouxu commented Nov 5, 2024

Urgau commented Nov 5, 2024 •

edited

Loading

jieyouxu commented Nov 6, 2024 •

edited

Loading

Urgau commented Nov 8, 2024

petrochenkov commented Nov 9, 2024

bors commented Nov 9, 2024

workingjubilee commented Nov 10, 2024 •

edited

Loading

workingjubilee commented Nov 10, 2024

bors commented Nov 10, 2024

This comment has been minimized.

Report the unexpected_cfgs lint in external macros #132577

Report the unexpected_cfgs lint in external macros #132577

Conversation

Urgau commented Nov 3, 2024 • edited by workingjubilee Loading

rustbot commented Nov 3, 2024

This comment has been minimized.

rustbot commented Nov 4, 2024

Urgau commented Nov 4, 2024

This comment has been minimized.

jieyouxu commented Nov 5, 2024

Urgau commented Nov 5, 2024 • edited Loading

jieyouxu commented Nov 6, 2024 • edited Loading

Urgau commented Nov 8, 2024

petrochenkov commented Nov 9, 2024

bors commented Nov 9, 2024

workingjubilee commented Nov 10, 2024 • edited Loading

workingjubilee commented Nov 10, 2024

bors commented Nov 10, 2024

This comment has been minimized.

Report the `unexpected_cfgs` lint in external macros #132577

Report the `unexpected_cfgs` lint in external macros #132577

Urgau commented Nov 3, 2024 •

edited by workingjubilee

Loading

Urgau commented Nov 5, 2024 •

edited

Loading

jieyouxu commented Nov 6, 2024 •

edited

Loading

workingjubilee commented Nov 10, 2024 •

edited

Loading