Bump compiler_builtins #123426
Closed
Bump compiler_builtins #123426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Thanks for doing this! Could you try removing this line?: I'm not sure if that would work, this heavily assumes that the symbols Rust uses from FWIW, here's a list of symbols provided by |
That is not easily doable. The build fails during stage0 -> stage1 compiler build which means it's still using prebuilt toolchain. |
Ah, OK. I'm not sure if we could use --- a/src/x86.rs
+++ b/src/x86.rs
@@ -12,6 +12,7 @@ intrinsics! {
#[cfg(all(
windows,
target_env = "gnu",
+ any(not(bootstrap), target_abi = "llvm"),
not(feature = "no-asm")
))]
pub unsafe extern "C" fn _alloca() {i.e. make |
|
No idea if that would work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost
cc rust-lang/compiler-builtins#585