Fix stack overflow issue in redundant_pattern_matching
#7170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
flip1995
force-pushed
the
revert_drop_order
branch
2 times, most recently
from
1612002 to
08454be
Compare
|
Here I think this should fix it camsteffen@a6a2fea |
flip1995
force-pushed
the
revert_drop_order
branch
from
08454be to
59874f3
Compare
flip1995
added
the
I-sync-blocker
|
Thank you! @bors r+ |
|
📌 Commit 59874f3 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
flip1995
removed
the
I-sync-blocker
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 10, 2021
Fix stack overflow issue in `redundant_pattern_matching` Fixes rust-lang#7169 ~~cc `@Jarcho` Since tomorrow is release day and we need to get this also fixed in beta, I'll just revert the PR instead of looking into the root issue. Your changes are good, so if you have an idea what could cause this stack overflow and know how to fix it, please open a PR that reverts this revert with a fix.~~ r? `@llogiq` changelog: none (fixes stack overflow, but this was introduced in this release cycle)
bors
added a commit
that referenced
this pull request
May 10, 2021
Backport #7170 to beta changelog: none (fixes stack overflow, but this was introduced in this release cycle)
bors
added a commit
that referenced
this pull request
May 10, 2021
Backport of #7170 to beta r? `@ghost` changelog: none (fixes stack overflow, but this was introduced in this release cycle) Now actually opened towards the `beta` branch.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 8, 2021
…lacrum [Beta] Backport ICE fix in Clippy This backports an ICE / stack overflow fix from rust-lang/rust-clippy#7170. cc rust-lang/rust-clippy#7169 cc `@llogiq` `@camsteffen` r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7169
cc @Jarcho Since tomorrow is release day and we need to get this also fixed in beta, I'll just revert the PR instead of looking into the root issue. Your changes are good, so if you have an idea what could cause this stack overflow and know how to fix it, please open a PR that reverts this revert with a fix.r? @llogiq
changelog: none (fixes stack overflow, but this was introduced in this release cycle)