Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Downgrade new_ret_no_self to pedantic" #5442

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Apr 9, 2020

Reverts #5420

This got through with the big rollup merge, where I didn't recheck every PR of the rollup. Reverting because of the reason given in #5420 (comment) by @joshtriplett

changelog: Move new_ret_no_self back to style category

@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 9, 2020
@flip1995 flip1995 requested a review from Manishearth April 9, 2020 17:41
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 9, 2020

📌 Commit 90fb50f has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Apr 9, 2020

⌛ Testing commit 90fb50f with merge 34763a5...

@bors
Copy link
Contributor

bors commented Apr 9, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 34763a5 to master...

@bors bors merged commit 34763a5 into master Apr 9, 2020
@flip1995 flip1995 deleted the revert-5420-newret branch April 9, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants