add manual_slice_fill lint
#14082
Open
add manual_slice_fill lint
#14082
+432
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
lapla-cogito
force-pushed
the
manual_slice_fill
branch
from
a7f0cf8 to
2318bbb
Compare
|
r? clippy still a bit busy, trying not to do new lint reviews |
lapla-cogito
force-pushed
the
manual_slice_fill
branch
from
2318bbb to
d7bd4a0
Compare
llogiq
reviewed
Jan 28, 2025
Comment on lines
27
to
45
| if msrv.meets(msrvs::SLICE_FILL) | ||
| && let Some(higher::Range { | ||
| start: Some(start), | ||
| end: Some(end), | ||
| limits: RangeLimits::HalfOpen, | ||
| }) = higher::Range::hir(arg) | ||
| && let ExprKind::Lit(Spanned { | ||
| node: LitKind::Int(Pu128(0), _), | ||
| .. | ||
| }) = start.kind | ||
| && let ExprKind::Block(_, _) = body.kind | ||
| && let ExprKind::Assign(assignee, assignval, _) = peel_blocks_with_stmt(body).kind | ||
| && let ExprKind::Index(slice, _, _) = assignee.kind | ||
| && let ExprKind::MethodCall(path, recv, _, _) = end.kind | ||
| && let ExprKind::Path(Resolved(_, recvpath)) = recv.kind | ||
| && let ExprKind::Path(Resolved(_, slicepath)) = slice.kind | ||
| && switch_to_eager_eval(cx, assignval) | ||
| && span_is_local(assignval.span) | ||
| && path.ident.name == sym::len |
There was a problem hiding this comment.
This code could do with either some functions to abstract things or comments to explain them. I was able to trace what is being matched where, but it could certainly be easier to follow.
llogiq
reviewed
Jan 28, 2025
Comment on lines
+728
to
+730
| /// for i in 0..some_slice.len() { | ||
| /// some_slice[i] = 0; | ||
| /// } |
There was a problem hiding this comment.
Should we also try to detect for i in &mut some_slice { *i = 0; }?
There was a problem hiding this comment.
Right, implementation added to allow detection of such patterns as well. Thanks!
lapla-cogito
force-pushed
the
manual_slice_fill
branch
from
d7bd4a0 to
801090f
Compare
lapla-cogito
force-pushed
the
manual_slice_fill
branch
from
801090f to
913adc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13856
changelog: [
manual_slice_fill]: new lint