Better help message for comparison_chain lint #13762
Conversation
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-ukyxvovullmy
branch
from
3f1a571 to
975e3ed
Compare
|
r? @y21 |
clippy_lints/src/comparison_chain.rs
Outdated
| span_lint_and_help( | ||
| cx, | ||
| COMPARISON_CHAIN, | ||
| expr.span, | ||
| "`if` chain can be rewritten with `match`", | ||
| None, | ||
| "consider rewriting the `if` chain to use `cmp` and `match`", | ||
| format!("consider rewriting the `if` chain with: `match {lhs}.cmp({rhs}) {{...}}`"), |
There was a problem hiding this comment.
At this point now that we're giving code snippets to the user and reference real code the user wrote (esp. with the colon) I feel like it would make sense to start giving this its own actual verbose suggestion with Applicability::HasPlaceholders. That seems like it would also help with making it easier to spot this part of the diagnostic.
There was a problem hiding this comment.
You mean like this? (I just pushed a revised version)
There was a problem hiding this comment.
I meant span_lint_and_then + span_suggestion_verbose, so that the suggestion gets put on its own line at the bottom, but this is fine too
samueltardieu
force-pushed
the
push-ukyxvovullmy
branch
from
975e3ed to
69411e0
Compare
changelog: [
comparison_chain]: give explicit help message showing a clear suggestionClose #13739