Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint for overindented list items in docs #13711

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ohno418
Copy link

@ohno418 ohno418 commented Nov 20, 2024

Add a lint to detect and fix list items in docs that are overindented.

For example,

/// - first line
///      second line
fn foo() {}

this would be fixed to:

/// - first line
///   second line
fn foo() {}

This lint improves readabiliy and consistency in doc.


changelog: [doc_lazy_continuation]: Added a lint to detect list items that are overindented
fixes: #13601

Add a lint to detect and fix list items in docs that are overindented.

For example,

```rs
/// - first line
///      second line
fn foo() {}
```

this would be fixed to:

```rs
/// - first line
///   second line
fn foo() {}
```

This lint improves readabiliy and consistency in doc.
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Centri3 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 20, 2024
@bors
Copy link
Contributor

bors commented Dec 3, 2024

☔ The latest upstream changes (presumably 19426bf) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me, but I think it's best as a separate lint instead. As a separate lint it can still use the same code of course.

/// },
/// {
/// 'data': 0x0105 # to indicate 1.5
/// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add error annotations here for consistency, like has already been done with it having no indentation.

| ^^^^^^^^^^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
help: indent this line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy+paste error? Over-indenting and under-indenting both say this.

@ohno418
Copy link
Author

ohno418 commented Dec 15, 2024

I think it's best as a separate lint instead.

Makes sense. I'll make a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overindented lines lint (similar to doc_lazy_continuation)
4 participants